Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-2944

SourceMeasurementTask still referenced in our stack

    XMLWordPrintable

    Details

      Description

      SourceMeasurementTask is gone, but we still have code that refers to it, including:

      /Users/rowen/LSST/lsstsw/build/meas_algorithms/python/lsst/meas/algorithms/debugger.py:
         21: from lsst.meas.algorithms.measurement import SourceMeasurementTask
         26:     measurement = ConfigurableField(target=SourceMeasurementTask, doc="Measurements")
       
      /Users/rowen/LSST/lsstsw/build/meas_algorithms/python/lsst/meas/algorithms/detection.py:
        209: The example also runs the SourceMeasurementTask; see \ref meas_algorithms_measurement_Example for more explanation.
       
      /Users/rowen/LSST/lsstsw/build/meas_deblender/examples/utils.py:
         15: class DebugSourceMeasTask(measAlg.SourceMeasurementTask):
         41:         measAlg.SourceMeasurementTask.preMeasureHook(self, exposure, sources)
         74:         measAlg.SourceMeasurementTask.postMeasureHook(self, exposure, sources)
         80:         measAlg.SourceMeasurementTask.preSingleMeasureHook(self, exposure, sources, i)
        102:         measAlg.SourceMeasurementTask.postSingleMeasureHook(self, exposure, sources, i)
       
      /Users/rowen/LSST/lsstsw/build/meas_deblender/python/lsst/meas/deblender/deblendAndMeasure.py:
         31: from lsst.meas.algorithms import SourceMeasurementTask
         50:         target = SourceMeasurementTask,
       
      /Users/rowen/LSST/lsstsw/build/pipe_tasks/python/lsst/pipe/tasks/calibrate.py:
        180: <DT> initialMeasurement \ref SourceMeasurementTask_ "SourceMeasurementTask"
        189: <DT> measurement \ref SourceMeasurementTask_ "SourceMeasurementTask"
       
      /Users/rowen/LSST/lsstsw/build/pipe_tasks/python/lsst/pipe/tasks/imageDifference.py:
         36: from lsst.meas.algorithms import SourceDetectionTask, SourceMeasurementTask, \
        104:         target=SourceMeasurementTask,
       
      /Users/rowen/LSST/lsstsw/build/pipe_tasks/python/lsst/pipe/tasks/measurePsf.py:
        136: The example also runs SourceDetectionTask and SourceMeasurementTask; see \ref meas_algorithms_measurement_Example for more explanation.
      

      I will handle pipe_tasks calibrate.py as part of DM-435.

        Attachments

          Issue Links

            Activity

            rowen Russell Owen created issue -
            Hide
            yusra Yusra AlSayyad added a comment -

            Just ran into this while dusting off ImageDifferenceTask.

            Show
            yusra Yusra AlSayyad added a comment - Just ran into this while dusting off ImageDifferenceTask.
            yusra Yusra AlSayyad made changes -
            Field Original Value New Value
            Link This issue relates to DM-3213 [ DM-3213 ]
            swinbank John Swinbank made changes -
            Team Data Release Production [ 10301 ]
            Hide
            swinbank John Swinbank added a comment -

            By "ran into", do you mean "was blocked from performing scheduled work and/or achieving my science goals", or just as in "noticed it will be an issue someday"?

            Show
            swinbank John Swinbank added a comment - By "ran into", do you mean "was blocked from performing scheduled work and/or achieving my science goals", or just as in "noticed it will be an issue someday"?
            Hide
            yusra Yusra AlSayyad added a comment -

            I mean blocked. I'll take pipe_tasks/python/lsst/pipe/tasks/imageDifference.py as part of DM-3213.

            Show
            yusra Yusra AlSayyad added a comment - I mean blocked. I'll take pipe_tasks/python/lsst/pipe/tasks/imageDifference.py as part of DM-3213 .
            gcomoretto Gabriele Comoretto made changes -
            Remote Link This issue links to "Page (Confluence)" [ 20176 ]
            Hide
            swinbank John Swinbank added a comment -

            Hey Fred, do you have time for a trivial review? This is pretty much all minor doc changes except for some significant removal of obviously-dead code in meas_deblender and meas_algorithms.

            PRs here:

            Show
            swinbank John Swinbank added a comment - Hey Fred, do you have time for a trivial review? This is pretty much all minor doc changes except for some significant removal of obviously-dead code in meas_deblender and meas_algorithms. PRs here: https://github.com/lsst/meas_deblender/pull/68 https://github.com/lsst/meas_algorithms/pull/159 https://github.com/lsst/ip_diffim/pull/118 https://github.com/lsst/pipe_tasks/pull/283
            swinbank John Swinbank made changes -
            Reviewers Fred Moolekamp [ fred3m ]
            Status To Do [ 10001 ] In Review [ 10004 ]
            swinbank John Swinbank made changes -
            Assignee John Swinbank [ swinbank ]
            swinbank John Swinbank made changes -
            Epic Link DM-17887 [ 240317 ]
            swinbank John Swinbank made changes -
            Story Points 1
            Team Data Release Production [ 10301 ] Alert Production [ 10300 ]
            Show
            swinbank John Swinbank added a comment - Jenkins: https://ci.lsst.codes/job/stack-os-matrix/29611/
            Hide
            fred3m Fred Moolekamp added a comment -

            Sure, I should be able to review this tomorrow.

            Show
            fred3m Fred Moolekamp added a comment - Sure, I should be able to review this tomorrow.
            Hide
            fred3m Fred Moolekamp added a comment -

            Congratulations John Swinbank, you successfully deleted dead code.

            Show
            fred3m Fred Moolekamp added a comment - Congratulations John Swinbank , you successfully deleted dead code.
            fred3m Fred Moolekamp made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            Hide
            swinbank John Swinbank added a comment -

            w00t. Thanks Fred Moolekamp!

            Show
            swinbank John Swinbank added a comment - w00t. Thanks Fred Moolekamp !
            swinbank John Swinbank made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

              People

              Assignee:
              swinbank John Swinbank
              Reporter:
              rowen Russell Owen
              Reviewers:
              Fred Moolekamp
              Watchers:
              Fred Moolekamp, Jim Bosch, John Swinbank, Russell Owen, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: