[DM-29496] Update ts_wep import of DetectorType - Jira

XML

Word

Printable

Details

Type: Bug
Status: Done
Resolution: Done
Fix Version/s: None
Component/s: ts_aos
Labels:
- UW

Story Points:
1
Epic Link:
Integrate WEP into DM stack
Team:
Telescope and Site
Urgent?:
Yes

Description

~~DM-28658~~ requires a different way to import DetectorType from afw. Currently, with stack 2021_13, I get for ts_wep:

setup ts_wep -k -r /project/scichris/aos/ts_wep/

scons -c

scons: Reading SConscript files ...

 EUPS integration: enabled

 Setting up environment to build package 'ts_wep'.

 find . ( -name .svn -prune -o -name .git -prune -o -name * ) ( -name ~ -type f -o -name core -type f -o -name core.[1-9] -type f -o -name *.so -type f -o -name *.os -type f -o -name *.o -type f -o -name *.pyc -type f -o -name *.pkgc -type f ) -exec rm -f {} \; ; rm -rf .sconf_temp .sconsign.dblite .sconsign.tmp config.log ; find . ( -name .svn -prune -o -name .git -prune -o -name * ) ( -name .cache -type d -prune -o -name _pycache_ -type d -prune -o -name .pytest_cache -type d -prune ) -exec rm -rf {} \;

 ModuleNotFoundError: No module named 'lsst.afw.cameraGeom.detector':

 File "/project/scichris/aos/ts_wep/SConstruct", line 3:

 scripts.BasicSConstruct("ts_wep")

 File "/software/lsstsw/stack_20210211/stack/miniconda3-py38_4.9.2-0.4.1/Linux64/sconsUtils/21.0.0-7-gd4ecef8/python/lsst/sconsUtils/scripts.py", line 51:

 cls.initialize(packageName, versionString, eupsProduct, eupsProductPath, cleanExt,

 File "/software/lsstsw/stack_20210211/stack/miniconda3-py38_4.9.2-0.4.1/Linux64/sconsUtils/21.0.0-7-gd4ecef8/python/lsst/sconsUtils/scripts.py", line 153:

 SConscript(script)

 File "/software/lsstsw/stack_20210211/conda/miniconda3-py38_4.9.2/envs/lsst-scipipe/lib/python3.8/site-packages/SCons/Script/SConscript.py", line 654:

 return method(*args, **kw)

 File "/software/lsstsw/stack_20210211/conda/miniconda3-py38_4.9.2/envs/lsst-scipipe/lib/python3.8/site-packages/SCons/Script/SConscript.py", line 591:

 return _SConscript(self.fs, *files, **subst_kw)

 File "/software/lsstsw/stack_20210211/conda/miniconda3-py38_4.9.2/envs/lsst-scipipe/lib/python3.8/site-packages/SCons/Script/SConscript.py", line 280:

 exec(compile(scriptdata, scriptname, 'exec'), call_stack[-1].globals)

 File "/project/scichris/aos/ts_wep/python/lsst/ts/wep/cwfs/SConscript", line 2:

 from lsst.ts.wep.Utility import getModulePath

 File "/project/scichris/aos/ts_wep/python/lsst/ts/wep/_init_.py", line 5:

 from .SourceSelector import SourceSelector

 File "/project/scichris/aos/ts_wep/python/lsst/ts/wep/SourceSelector.py", line 25:

 from lsst.ts.wep.bsc.CamFactory import CamFactory

 File "/project/scichris/aos/ts_wep/python/lsst/ts/wep/bsc/CamFactory.py", line 23:

 from lsst.ts.wep.bsc.LsstCam import LsstCam

 File "/project/scichris/aos/ts_wep/python/lsst/ts/wep/bsc/LsstCam.py", line 23:

 from lsst.afw.cameraGeom.detector.detector import DetectorType

( Note: This error was not present in w_2021_12 , it is new to w_2021_13 ) .

Completion criteria:

Pass all scons tests.

Attachments

Issue Links

blocks

DM-29233 Update ts_phosim tests

Done

Activity

Ascending order - Click to sort in descending order

No builds found.

Krzysztof Suberlak created issue - 29/Mar/21 7:07 PM

Krzysztof Suberlak made changes - 29/Mar/21 7:07 PM

Field	Original Value	New Value
Link		This issue blocks ~~DM-29233~~ [ ~~DM-29233~~ ]

Krzysztof Suberlak made changes - 29/Mar/21 7:13 PM

Description

~~DM-28658~~ requires a different way to import {{DetectorType}} from {{afw}}. Currently, with stack 2021_13, I get for ts_wep:

setup ts_wep -k -r /project/scichris/aos/ts_wep/

scons -c

scons: Reading SConscript files ...
EUPS integration: enabled
Setting up environment to build package 'ts_wep'.
find . \( -name .svn -prune -o -name .git -prune -o -name \* \) \( -name \*~ -type f -o -name core -type f -o -name core.\[1-9]\* -type f -o -name \*.so -type f -o -name \*.os -type f -o -name \*.o -type f -o -name \*.pyc -type f -o -name \*.pkgc -type f \) -exec rm -f \{} \; ; rm -rf .sconf_temp .sconsign.dblite .sconsign.tmp config.log ; find . \( -name .svn -prune -o -name .git -prune -o -name \* \) \( -name .cache -type d -prune -o -name __pycache__ -type d -prune -o -name .pytest_cache -type d -prune \) -exec rm -rf \{} \;
ModuleNotFoundError: No module named 'lsst.afw.cameraGeom.detector':
  File "/project/scichris/aos/ts_wep/SConstruct", line 3:
    scripts.BasicSConstruct("ts_wep")
  File "/software/lsstsw/stack_20210211/stack/miniconda3-py38_4.9.2-0.4.1/Linux64/sconsUtils/21.0.0-7-gd4ecef8/python/lsst/sconsUtils/scripts.py", line 51:
    cls.initialize(packageName, versionString, eupsProduct, eupsProductPath, cleanExt,
  File "/software/lsstsw/stack_20210211/stack/miniconda3-py38_4.9.2-0.4.1/Linux64/sconsUtils/21.0.0-7-gd4ecef8/python/lsst/sconsUtils/scripts.py", line 153:
    SConscript(script)
  File "/software/lsstsw/stack_20210211/conda/miniconda3-py38_4.9.2/envs/lsst-scipipe/lib/python3.8/site-packages/SCons/Script/SConscript.py", line 654:
    return method(*args, **kw)
  File "/software/lsstsw/stack_20210211/conda/miniconda3-py38_4.9.2/envs/lsst-scipipe/lib/python3.8/site-packages/SCons/Script/SConscript.py", line 591:
    return _SConscript(self.fs, *files, **subst_kw)
  File "/software/lsstsw/stack_20210211/conda/miniconda3-py38_4.9.2/envs/lsst-scipipe/lib/python3.8/site-packages/SCons/Script/SConscript.py", line 280:
    exec(compile(scriptdata, scriptname, 'exec'), call_stack[-1].globals)
  File "/project/scichris/aos/ts_wep/python/lsst/ts/wep/cwfs/SConscript", line 2:
    from lsst.ts.wep.Utility import getModulePath
  File "/project/scichris/aos/ts_wep/python/lsst/ts/wep/__init__.py", line 5:
    from .SourceSelector import SourceSelector
  File "/project/scichris/aos/ts_wep/python/lsst/ts/wep/SourceSelector.py", line 25:
    from lsst.ts.wep.bsc.CamFactory import CamFactory
  File "/project/scichris/aos/ts_wep/python/lsst/ts/wep/bsc/CamFactory.py", line 23:
    from lsst.ts.wep.bsc.LsstCam import LsstCam
  File "/project/scichris/aos/ts_wep/python/lsst/ts/wep/bsc/LsstCam.py", line 23:
    from lsst.afw.cameraGeom.detector.detector import DetectorType

*Completion criteria:*

Pass all scons tests.

~~DM-28658~~ requires a different way to import {{DetectorType}} from {{afw}}. Currently, with stack 2021_13, I get for ts_wep:

setup ts_wep -k -r /project/scichris/aos/ts_wep/

scons -c

scons: Reading SConscript files ...
EUPS integration: enabled
Setting up environment to build package 'ts_wep'.
find . ( -name .svn -prune -o -name .git -prune -o -name * ) ( -name *~ -type f -o -name core -type f -o -name core.[1-9]* -type f -o -name *.so -type f -o -name *.os -type f -o -name *.o -type f -o -name *.pyc -type f -o -name *.pkgc -type f ) -exec rm -f \{} \; ; rm -rf .sconf_temp .sconsign.dblite .sconsign.tmp config.log ; find . ( -name .svn -prune -o -name .git -prune -o -name * ) ( -name .cache -type d -prune -o -name __pycache__ -type d -prune -o -name .pytest_cache -type d -prune ) -exec rm -rf \{} \;
ModuleNotFoundError: No module named 'lsst.afw.cameraGeom.detector':
File "/project/scichris/aos/ts_wep/SConstruct", line 3:
scripts.BasicSConstruct("ts_wep")
File "/software/lsstsw/stack_20210211/stack/miniconda3-py38_4.9.2-0.4.1/Linux64/sconsUtils/21.0.0-7-gd4ecef8/python/lsst/sconsUtils/scripts.py", line 51:
cls.initialize(packageName, versionString, eupsProduct, eupsProductPath, cleanExt,
File "/software/lsstsw/stack_20210211/stack/miniconda3-py38_4.9.2-0.4.1/Linux64/sconsUtils/21.0.0-7-gd4ecef8/python/lsst/sconsUtils/scripts.py", line 153:
SConscript(script)
File "/software/lsstsw/stack_20210211/conda/miniconda3-py38_4.9.2/envs/lsst-scipipe/lib/python3.8/site-packages/SCons/Script/SConscript.py", line 654:
return method(*args, **kw)
File "/software/lsstsw/stack_20210211/conda/miniconda3-py38_4.9.2/envs/lsst-scipipe/lib/python3.8/site-packages/SCons/Script/SConscript.py", line 591:
return _SConscript(self.fs, *files, **subst_kw)
File "/software/lsstsw/stack_20210211/conda/miniconda3-py38_4.9.2/envs/lsst-scipipe/lib/python3.8/site-packages/SCons/Script/SConscript.py", line 280:
exec(compile(scriptdata, scriptname, 'exec'), call_stack[-1].globals)
File "/project/scichris/aos/ts_wep/python/lsst/ts/wep/cwfs/SConscript", line 2:
from lsst.ts.wep.Utility import getModulePath
File "/project/scichris/aos/ts_wep/python/lsst/ts/wep/__init__.py", line 5:
from .SourceSelector import SourceSelector
File "/project/scichris/aos/ts_wep/python/lsst/ts/wep/SourceSelector.py", line 25:
from lsst.ts.wep.bsc.CamFactory import CamFactory
File "/project/scichris/aos/ts_wep/python/lsst/ts/wep/bsc/CamFactory.py", line 23:
from lsst.ts.wep.bsc.LsstCam import LsstCam
File "/project/scichris/aos/ts_wep/python/lsst/ts/wep/bsc/LsstCam.py", line 23:
from lsst.afw.cameraGeom.detector.detector import DetectorType

( Note: This error was not present in {{w_2021_12}} , it is new to {{w_2021_13}} ) .

*Completion criteria:*

Pass all scons tests.

Krzysztof Suberlak made changes - 29/Mar/21 7:13 PM

Description

~~DM-28658~~ requires a different way to import {{DetectorType}} from {{afw}}. Currently, with stack 2021_13, I get for ts_wep:

setup ts_wep -k -r /project/scichris/aos/ts_wep/

scons -c

scons: Reading SConscript files ...
EUPS integration: enabled
Setting up environment to build package 'ts_wep'.
find . ( -name .svn -prune -o -name .git -prune -o -name * ) ( -name *~ -type f -o -name core -type f -o -name core.[1-9]* -type f -o -name *.so -type f -o -name *.os -type f -o -name *.o -type f -o -name *.pyc -type f -o -name *.pkgc -type f ) -exec rm -f \{} \; ; rm -rf .sconf_temp .sconsign.dblite .sconsign.tmp config.log ; find . ( -name .svn -prune -o -name .git -prune -o -name * ) ( -name .cache -type d -prune -o -name __pycache__ -type d -prune -o -name .pytest_cache -type d -prune ) -exec rm -rf \{} \;
ModuleNotFoundError: No module named 'lsst.afw.cameraGeom.detector':
File "/project/scichris/aos/ts_wep/SConstruct", line 3:
scripts.BasicSConstruct("ts_wep")
File "/software/lsstsw/stack_20210211/stack/miniconda3-py38_4.9.2-0.4.1/Linux64/sconsUtils/21.0.0-7-gd4ecef8/python/lsst/sconsUtils/scripts.py", line 51:
cls.initialize(packageName, versionString, eupsProduct, eupsProductPath, cleanExt,
File "/software/lsstsw/stack_20210211/stack/miniconda3-py38_4.9.2-0.4.1/Linux64/sconsUtils/21.0.0-7-gd4ecef8/python/lsst/sconsUtils/scripts.py", line 153:
SConscript(script)
File "/software/lsstsw/stack_20210211/conda/miniconda3-py38_4.9.2/envs/lsst-scipipe/lib/python3.8/site-packages/SCons/Script/SConscript.py", line 654:
return method(*args, **kw)
File "/software/lsstsw/stack_20210211/conda/miniconda3-py38_4.9.2/envs/lsst-scipipe/lib/python3.8/site-packages/SCons/Script/SConscript.py", line 591:
return _SConscript(self.fs, *files, **subst_kw)
File "/software/lsstsw/stack_20210211/conda/miniconda3-py38_4.9.2/envs/lsst-scipipe/lib/python3.8/site-packages/SCons/Script/SConscript.py", line 280:
exec(compile(scriptdata, scriptname, 'exec'), call_stack[-1].globals)
File "/project/scichris/aos/ts_wep/python/lsst/ts/wep/cwfs/SConscript", line 2:
from lsst.ts.wep.Utility import getModulePath
File "/project/scichris/aos/ts_wep/python/lsst/ts/wep/__init__.py", line 5:
from .SourceSelector import SourceSelector
File "/project/scichris/aos/ts_wep/python/lsst/ts/wep/SourceSelector.py", line 25:
from lsst.ts.wep.bsc.CamFactory import CamFactory
File "/project/scichris/aos/ts_wep/python/lsst/ts/wep/bsc/CamFactory.py", line 23:
from lsst.ts.wep.bsc.LsstCam import LsstCam
File "/project/scichris/aos/ts_wep/python/lsst/ts/wep/bsc/LsstCam.py", line 23:
from lsst.afw.cameraGeom.detector.detector import DetectorType

( Note: This error was not present in {{w_2021_12}} , it is new to {{w_2021_13}} ) .

*Completion criteria:*

Pass all scons tests.

~~DM-28658~~ requires a different way to import {{DetectorType}} from {{afw}}. Currently, with stack 2021_13, I get for ts_wep:

setup ts_wep -k -r /project/scichris/aos/ts_wep/

{code:java}
scons -c
scons: Reading SConscript files ...
EUPS integration: enabled
Setting up environment to build package 'ts_wep'.
find . ( -name .svn -prune -o -name .git -prune -o -name * ) ( -name ~ -type f -o -name core -type f -o -name core.[1-9] -type f -o -name *.so -type f -o -name *.os -type f -o -name *.o -type f -o -name *.pyc -type f -o -name *.pkgc -type f ) -exec rm -f {} \; ; rm -rf .sconf_temp .sconsign.dblite .sconsign.tmp config.log ; find . ( -name .svn -prune -o -name .git -prune -o -name * ) ( -name .cache -type d -prune -o -name _pycache_ -type d -prune -o -name .pytest_cache -type d -prune ) -exec rm -rf {} \;
ModuleNotFoundError: No module named 'lsst.afw.cameraGeom.detector':
File "/project/scichris/aos/ts_wep/SConstruct", line 3:
scripts.BasicSConstruct("ts_wep")
File "/software/lsstsw/stack_20210211/stack/miniconda3-py38_4.9.2-0.4.1/Linux64/sconsUtils/21.0.0-7-gd4ecef8/python/lsst/sconsUtils/scripts.py", line 51:
cls.initialize(packageName, versionString, eupsProduct, eupsProductPath, cleanExt,
File "/software/lsstsw/stack_20210211/stack/miniconda3-py38_4.9.2-0.4.1/Linux64/sconsUtils/21.0.0-7-gd4ecef8/python/lsst/sconsUtils/scripts.py", line 153:
SConscript(script)
File "/software/lsstsw/stack_20210211/conda/miniconda3-py38_4.9.2/envs/lsst-scipipe/lib/python3.8/site-packages/SCons/Script/SConscript.py", line 654:
return method(*args, **kw)
File "/software/lsstsw/stack_20210211/conda/miniconda3-py38_4.9.2/envs/lsst-scipipe/lib/python3.8/site-packages/SCons/Script/SConscript.py", line 591:
return _SConscript(self.fs, *files, **subst_kw)
File "/software/lsstsw/stack_20210211/conda/miniconda3-py38_4.9.2/envs/lsst-scipipe/lib/python3.8/site-packages/SCons/Script/SConscript.py", line 280:
exec(compile(scriptdata, scriptname, 'exec'), call_stack[-1].globals)
File "/project/scichris/aos/ts_wep/python/lsst/ts/wep/cwfs/SConscript", line 2:
from lsst.ts.wep.Utility import getModulePath
File "/project/scichris/aos/ts_wep/python/lsst/ts/wep/_init_.py", line 5:
from .SourceSelector import SourceSelector
File "/project/scichris/aos/ts_wep/python/lsst/ts/wep/SourceSelector.py", line 25:
from lsst.ts.wep.bsc.CamFactory import CamFactory
File "/project/scichris/aos/ts_wep/python/lsst/ts/wep/bsc/CamFactory.py", line 23:
from lsst.ts.wep.bsc.LsstCam import LsstCam
File "/project/scichris/aos/ts_wep/python/lsst/ts/wep/bsc/LsstCam.py", line 23:
from lsst.afw.cameraGeom.detector.detector import DetectorType
{code}

( Note: This error was not present in {{w_2021_12}} , it is new to {{w_2021_13}} ) .

*Completion criteria:*

Pass all scons tests.

Krzysztof Suberlak made changes - 29/Mar/21 7:21 PM

Status

To Do [ 10001 ]

In Progress [ 3 ]

Krzysztof Suberlak made changes - 29/Mar/21 8:10 PM

Reviewers		Te-Wei Tsai [ ttsai ]
Status	In Progress [ 3 ]	In Review [ 10004 ]

Hide

Permalink

Krzysztof Suberlak added a comment - 29/Mar/21 8:10 PM

Opened PR https://github.com/lsst-ts/ts_wep/pull/76 , all scons tests pass.

Show

Krzysztof Suberlak added a comment - 29/Mar/21 8:10 PM Opened PR https://github.com/lsst-ts/ts_wep/pull/76 , all scons tests pass.

Hide

Permalink

Te-Wei Tsai added a comment - 29/Mar/21 8:17 PM

The update looks good to me. Thanks!

Show

Te-Wei Tsai added a comment - 29/Mar/21 8:17 PM The update looks good to me. Thanks!

Te-Wei Tsai made changes - 29/Mar/21 8:17 PM

Status

In Review [ 10004 ]

Reviewed [ 10101 ]

Krzysztof Suberlak made changes - 30/Mar/21 4:15 AM

Resolution		Done [ 10000 ]
Status	Reviewed [ 10101 ]	Done [ 10002 ]

People

Assignee:: Krzysztof Suberlak

Reporter:: Krzysztof Suberlak

Reviewers:: Te-Wei Tsai

Watchers:: Krzysztof Suberlak, Te-Wei Tsai

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Due:: 29/Mar/21

Created:: 29/Mar/21 7:07 PM

Updated:: 30/Mar/21 4:15 AM

Resolved:: 30/Mar/21 4:15 AM

Start date:: 29/Mar/21

Jenkins

No builds found.

Data Management

Details

Description

Attachments

Issue Links

Activity

People

Dates

Jenkins