Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-29545

BaseCsc's constructor mis-handles invalid simulation_modes

    XMLWordPrintable

Details

    • 1
    • TSSW Sprint - Mar 29 - Apr 12
    • Telescope and Site
    • No

    Description

      BaseCsc checks for valid simulation mode after it starts the SalInfo object and before it sets some attributes. The effect is that if the simulation mode is rejected then cleanup routines are called (unnecessarily) that fail because of those missing attributes.

      Move the test for valid simulation modes earlier and make sure all attributes are set before calling the superclass constructor.

      Attachments

        Activity

          rowen Russell Owen added a comment - - edited

          I made construction and close more robust for several classes, to avoid accessing missing attributes in close methods. I also modified BaseCsc to check simulation_mode before calling the parent class constructor.

          Pull request: https://github.com/lsst-ts/ts_salobj/pull/186

          rowen Russell Owen added a comment - - edited I made construction and close more robust for several classes, to avoid accessing missing attributes in close methods. I also modified BaseCsc to check simulation_mode before calling the parent class constructor. Pull request: https://github.com/lsst-ts/ts_salobj/pull/186

          PR reviewed and approved.

          mareuter Michael Reuter added a comment - PR reviewed and approved.
          rowen Russell Owen added a comment -

          Released ts_salobj v6.3.4

          rowen Russell Owen added a comment - Released ts_salobj v6.3.4

          People

            rowen Russell Owen
            rowen Russell Owen
            Michael Reuter
            Michael Reuter, Russell Owen
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Jenkins

                No builds found.