Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-29563

Replace boost::variant, fix clang compilation

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • afw
    • None
    • 6
    • Data Release Production
    • No

    Description

      With RFC-759 more boost libraries can be replaced with their C+17 counterparts. When C+17 compilation is adopted, replace std::variant and fix clang compilation errors.

      Attachments

        Issue Links

          Activity

            Unfortunately, I don't have any suggestions for reducing the boilerplate – the reference_wrapper solution turned out to be a lot more complex than I expected.

            krzys Krzysztof Findeisen added a comment - Unfortunately, I don't have any suggestions for reducing the boilerplate – the reference_wrapper solution turned out to be a lot more complex than I expected.

            BTW, another ticket just reminded me that the afw COPYRIGHT file needs updating for 2020 and 2021 changes. Would this ticket be a good opportunity to do so?

            krzys Krzysztof Findeisen added a comment - BTW, another ticket just reminded me that the afw COPYRIGHT file needs updating for 2020 and 2021 changes. Would this ticket be a good opportunity to do so?

            Is this ready to merge after implementing krzys's suggestions.

            wittgen Matthias Wittgen added a comment - Is this ready to merge after implementing krzys 's suggestions.

            implemented krzys's suggestions, looked into jbosch's afw table changes and made some minor
            changes. All the clang-tidy changes are out.

            wittgen Matthias Wittgen added a comment - implemented krzys 's suggestions, looked into jbosch 's afw table changes and made some minor changes. All the clang-tidy changes are out.
            jbosch Jim Bosch added a comment -

            Looks good; just one new tiny style comment on the PR; feel free to merge after that is addressed.

            Sorry for all of the various things that kept slowing down this ticket, and thanks for bearing with it.

            jbosch Jim Bosch added a comment - Looks good; just one new tiny style comment on the PR; feel free to merge after that is addressed. Sorry for all of the various things that kept slowing down this ticket, and thanks for bearing with it.

            People

              wittgen Matthias Wittgen
              wittgen Matthias Wittgen
              Eli Rykoff, Jim Bosch
              Eli Rykoff, Jim Bosch, Krzysztof Findeisen, Matthias Wittgen
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.