Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-29570

Remove ignored fields from generic topics

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ts_middleware
    • Labels:
    • Story Points:
      0
    • Epic Link:
    • Sprint:
      TSSW Sprint - Mar 29 - Apr 12
    • Team:
      Telescope and Site
    • Urgent?:
      No

      Description

      SALGenerics.xml has many topics that have no public data. These all have one field that is intended to be ignored because at one time SAL required at least one public field. That restriction was removed a long time ago and these extra fields continue to confuse users. Time to remove them.

      The main risk to removing them is that it may break some existing code that reads or writes these fields. Such code should be easy to fix. A global search of the Python code I have checked out – which is most of it – showed no issues, but I'm a bit worried about the C++ and LabVIEW.

        Attachments

          Issue Links

            Activity

            Hide
            rowen Russell Owen added a comment -
            Show
            rowen Russell Owen added a comment - Pull request: https://github.com/lsst-ts/ts_xml/pull/433
            Hide
            rbovill Rob Bovill added a comment -

            PR approved and good to go.

            Show
            rbovill Rob Bovill added a comment - PR approved and good to go.
            Hide
            rowen Russell Owen added a comment -

            Merged to develop.

            Show
            rowen Russell Owen added a comment - Merged to develop.

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Rob Bovill
              Watchers:
              Dave Mills, Michael Reuter, Rob Bovill, Russell Owen, Tiago Ribeiro
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.