Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-29578

Please improve TCP/IP communications for the MT rotator and hexapod low-level controllers

    XMLWordPrintable

    Details

      Description

      The current TCP/IP communication with the low-level controller has several issues that I'd really like to see cleaned up, if you can find the time:

      • It does not report whether a given command succeeds or fails. I suggest adding a command ID integer that the CSC specified (and increments for each command) and reporting that integer with a code that indicates success or failure in the status. This will only allow acknowledging one command at a time, and requires polling, but I think we may have to live with that. A much more robust solution would be an asynchronous message as each command is implemented or rejected. But the current interface has no provision for asynchronous communication.
      • Communication is via two separate sockets, one which is only read, one which is only written. This is nuts because TCP/IP sockets are intrinsically bidirectional. Please combine them. This should be a simple change. It is well worth doing, in my opinion, because it reduces the failure modes. With a single socket we are either connected or not. With 2 sockets either or both can be disconnected.
      • The server is in the CSC and the client is in the low-level controller. If possible, please turn this around. That would allow us to manage the CSCs with Kubernetes – a big win. It also puts the configuration in the logical place (the CSC).

        Attachments

          Issue Links

            Activity

            No builds found.
            rowen Russell Owen created issue -
            rowen Russell Owen made changes -
            Field Original Value New Value
            Link This issue relates to DM-29577 [ DM-29577 ]
            ttsai Te-Wei Tsai made changes -
            Epic Link DM-27621 [ 441885 ]
            Labels HexRot M2Hexapod camera_hexapod hexapod
            ttsai Te-Wei Tsai made changes -
            Labels HexRot M2Hexapod camera_hexapod hexapod HexRot M2Hexapod Rotator camera_hexapod hexapod
            ttsai Te-Wei Tsai made changes -
            Link This issue relates to DM-31111 [ DM-31111 ]
            ttsai Te-Wei Tsai made changes -
            Link This issue is triggering DM-31820 [ DM-31820 ]
            ttsai Te-Wei Tsai made changes -
            Link This issue relates to DM-31883 [ DM-31883 ]
            aclements Andy Clements made changes -
            Epic Link DM-27621 [ 441885 ]
            ttsai Te-Wei Tsai made changes -
            Epic Link DM-32113 [ 770361 ]
            Watchers Bo Xin, Russell Owen, Tiago Ribeiro [ Bo Xin, Russell Owen, Tiago Ribeiro ] Russell Owen, Tiago Ribeiro [ Russell Owen, Tiago Ribeiro ]
            ttsai Te-Wei Tsai made changes -
            Epic Link DM-32113 [ 770361 ] DM-27623 [ 441888 ]
            ttsai Te-Wei Tsai made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            Hide
            ttsai Te-Wei Tsai added a comment -

            This ticket was implemented already from other tickets.

            Show
            ttsai Te-Wei Tsai added a comment - This ticket was implemented already from other tickets.
            ttsai Te-Wei Tsai made changes -
            Reviewers Russell Owen [ rowen ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            ttsai Te-Wei Tsai made changes -
            Story Points 0
            Hide
            rowen Russell Owen added a comment -

            Thank you very much for these great improvements.

            Show
            rowen Russell Owen added a comment - Thank you very much for these great improvements.
            rowen Russell Owen made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            ttsai Te-Wei Tsai made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

              People

              Assignee:
              ttsai Te-Wei Tsai
              Reporter:
              rowen Russell Owen
              Reviewers:
              Russell Owen
              Watchers:
              Russell Owen, Te-Wei Tsai, Tiago Ribeiro
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.