Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-29701

Latest weekly build fails when building utils

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: utils
    • Labels:
      None
    • Story Points:
      0.5
    • Team:
      Architecture
    • Urgent?:
      No

      Description

      The following test failure is reported when building utils

      =================================== FAILURES ===================================
      __________________ DeprecatedTestCase.test_deprecate_pybind11 __________________
      [gw6] linux -- Python 3.8.8 /home/centos/lsst_stack/conda/miniconda3-py38_4.9.2/envs/lsst-scipipe-0.4.1/bin/python3.8
      self = <test_deprecated.DeprecatedTestCase testMethod=test_deprecate_pybind11>
      def test_deprecate_pybind11(self):
       def old(x):
       """Docstring"""
       return x + 1
       # Use an unusual category
      > old = lsst.utils.deprecate_pybind11(
       old, reason="For testing.", category=PendingDeprecationWarning)
      tests/test_deprecated.py:34: 
      _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
      python/lsst/utils/deprecated.py:72: in deprecate_pybind11
       return deprecated.sphinx.deprecated(
      ../../../../../../conda/miniconda3-py38_4.9.2/envs/lsst-scipipe-0.4.1/lib/python3.8/site-packages/deprecated/classic.py:267: in deprecated
       adapter = adapter_cls(**kwargs)
      _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
      self = <deprecated.sphinx.SphinxAdapter object at 0x7f25bb387670>
      directive = 'deprecated', reason = 'For testing.', version = None, action = None
      category = <class 'PendingDeprecationWarning'>, line_length = 70
      def __init__(
       self,
       directive,
       reason="",
       version="",
       action=None,
       category=DeprecationWarning,
       line_length=70,
       ):
       """
       Construct a wrapper adapter.
       
       :type directive: str
       :param directive:
       Sphinx directive: can be one of "versionadded", "versionchanged" or "deprecated".
       
       :type reason: str
       :param reason:
       Reason message which documents the deprecation in your library (can be omitted).
       
       :type version: str
       :param version:
       Version of your project which deprecates this feature.
       If you follow the `Semantic Versioning <https://semver.org/>`_,
       the version number has the format "MAJOR.MINOR.PATCH".
       
       :type action: str
       :param action:
       A warning filter used to activate or not the deprecation warning.
       Can be one of "error", "ignore", "always", "default", "module", or "once".
       If ``None`` or empty, the the global filtering mechanism is used.
       See: `The Warnings Filter`_ in the Python documentation.
       
       :type category: type
       :param category:
       The warning category to use for the deprecation warning.
       By default, the category class is :class:`~DeprecationWarning`,
       you can inherit this class to define your own deprecation warning category.
       
       :type line_length: int
       :param line_length:
       Max line length of the directive text. If non nul, a long text is wrapped in several lines.
       """
       if not version:
       # https://github.com/tantale/deprecated/issues/40
      > raise ValueError("'version' argument is required in Sphinx directives")
      E ValueError: 'version' argument is required in Sphinx directives
      ../../../../../../conda/miniconda3-py38_4.9.2/envs/lsst-scipipe-0.4.1/lib/python3.8/site-packages/deprecated/sphinx.py:89: ValueError
      

       

        Attachments

          Issue Links

            Activity

            Hide
            ktl Kian-Tat Lim added a comment -

            This appears to be due to conda-forge updating to deprecated 1.2.12 from 1.2.10 today.

            Show
            ktl Kian-Tat Lim added a comment - This appears to be due to conda-forge updating to deprecated 1.2.12 from 1.2.10 today.
            Hide
            tjenness Tim Jenness added a comment -

            Yes, I fixed most things in DM-29509 but forgot about the pybind11 wrapper (and hadn't tested it fully because conda-forge didn't have it).

            Show
            tjenness Tim Jenness added a comment - Yes, I fixed most things in DM-29509 but forgot about the pybind11 wrapper (and hadn't tested it fully because conda-forge didn't have it).
            Hide
            tjenness Tim Jenness added a comment - - edited

            Kian-Tat Lim I think I only needed to fix utils. I've looked at the deprecate_pybind11 usage in afw and it always sets the version there. Jenkins is running.

            Show
            tjenness Tim Jenness added a comment - - edited Kian-Tat Lim I think I only needed to fix utils. I've looked at the deprecate_pybind11 usage in afw and it always sets the version there. Jenkins is running.
            Hide
            ktl Kian-Tat Lim added a comment -

            It looks like there is one example in the Deprecating Interfaces page of the Dev Guide that still lacks a version parameter. I'll go fix that.

            Show
            ktl Kian-Tat Lim added a comment - It looks like there is one example in the Deprecating Interfaces page of the Dev Guide that still lacks a version parameter. I'll go fix that.

              People

              Assignee:
              tjenness Tim Jenness
              Reporter:
              dinob Dino Bektesevic
              Reviewers:
              Kian-Tat Lim
              Watchers:
              Dino Bektesevic, Kian-Tat Lim, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.