Details
-
Type:
Improvement
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ts_aos
-
Labels:
-
Story Points:2
-
Epic Link:
-
Team:Telescope and Site
Description
Update in `phosim_repackager.py` the repackaged FITS header `ROTANG` , so that the correct WCS is achieved. Currently, one needs to feed `90+/-ROTANG` to `lsst.obs.base.createInitialSkyWcsFromBoresight` to achieve the match. An illustration (attached) shows a simulated `lsstCam` defocal image, with red circles corresponding to locations of stars inferred from the input catalog assuming `90+ROTANG`
minimal code used to make the image is attached- wcs_code.py
Crucial part is
new_wcs = createInitialSkyWcsFromBoresight(pointing_loc,
|
(postIsr_md['ROTANG']+90)*lsst.geom.degrees, |
exposure.getDetector(),
|
flipX=False,)
|
since we desire to be able to use just {{postIsr_md['ROTANG'] }}, without adding 90 degrees to make the input catalog match the WCS information.
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Status | To Do [ 10001 ] | In Progress [ 3 ] |
| Description |
Update in `{{phosim_repackager.py`}} the repackaged FITS header `{{ROTANG}}` , so that the correct WCS is achieved. Currently, one needs to feed `{{90+/-ROTANG}}` to {{`lsst.obs.base.createInitialSkyWcsFromBoresight`}} to achieve the match. An illustration (attached) shows a simulated `{{lsstCam}}` defocal image, with red circles corresponding to locations of stars inferred from the input catalog assuming `90+ROTANG`
!image-2021-04-12-21-01-37-772.png|width=350,height=336! minimal code used to make the image is attached- [^wcs_code.py] |
Update in `{{phosim_repackager.py`}} the repackaged FITS header `{{ROTANG}}` , so that the correct WCS is achieved. Currently, one needs to feed `{{90+/-ROTANG}}` to {{`lsst.obs.base.createInitialSkyWcsFromBoresight`}} to achieve the match. An illustration (attached) shows a simulated `{{lsstCam}}` defocal image, with red circles corresponding to locations of stars inferred from the input catalog assuming `90+ROTANG`
!image-2021-04-12-21-01-37-772.png|width=350,height=336! minimal code used to make the image is attached- [^wcs_code.py] Crucial part is {code:java} new_wcs = createInitialSkyWcsFromBoresight(pointing_loc, (postIsr_md['ROTANG']+90)*lsst.geom.degrees, exposure.getDetector(), flipX=False,){code} since we desire to be able to use just {{postIsr_md['ROTANG'] }}, without adding 90 degrees to make the input catalog match the WCS information. |
| Reviewers | Te-Wei Tsai [ ttsai ] | |
| Status | In Progress [ 3 ] | In Review [ 10004 ] |
This PR looks good to me. Please discuss with Bryce for the possible break in ts_wep for the assumption of 90 degree. Thanks!
| Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
Merged and released as v0.2.4, discussed with Bryce the changes (he suggested them originally)
| Resolution | Done [ 10000 ] | |
| Status | Reviewed [ 10101 ] | Done [ 10002 ] |
Opened PR https://github.com/lsst-dm/phosim_utils/pull/16