Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-29725

Incorrect definitions of the command-line parameters in qserv-replica-config

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: Qserv
    • Labels:
      None

      Description

      The bug

      The current implementation of the configuration management tool qserv-replica-config has a bug in the definition of the optional parameters of the ADD_WORKER command by registering the optional parameters as positional and required (rather than options):

      ADD_WORKER  <worker> <service-host> <fs-host> <db-host> <loader-host> <exporter-host> <http-loader-host>
        [<service-port>] [<fs-port>] [<data-dir>] [<enabled>] [<read-only>]
        [<db-port>] [<db-user>] [<loader-port>] [<loader-tmp-dir>] [<exporter-port>] [<exporter-tmp-dir>]
        [<http-loader-port>] [<http-loader-tmp-dir>]
      

      The desired syntax should be:

      ADD_WORKER  <worker> <service-host>
        [--fs-host=<host>] [--db-host=<host>] [--loader-host=<host>]
        [--exporter-host=<host>] [--http-loader-host=<host>] [--service-port=<port>] [--fs-port=<port>]
        [--data-dir=<path>] [--enabled={0|1}] [--read-only={0|1}] [--db-port=<port>] [--db-user=<account>]
        [--loader-port=<port>] [--loader-tmp-dir=<path>] [--exporter-port=<port>]
        [--exporter-tmp-dir=<path>] [--http-loader-port=<port>] [--http-loader-tmp-dir=<path>]
      

      Other improvements

      • Reduce code duplication in the parser configuration section of the application.
      • Document commands.

        Attachments

          Issue Links

            Activity

            Hide
            jgates John Gates added a comment -

            Looks good.

            Show
            jgates John Gates added a comment - Looks good.

              People

              Assignee:
              gapon Igor Gaponenko
              Reporter:
              gapon Igor Gaponenko
              Reviewers:
              John Gates
              Watchers:
              Fritz Mueller, Igor Gaponenko, John Gates, Nate Pease
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: