# Please get rid of "char" and "octet" data types

XMLWordPrintable

#### Details

• Type: Story
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
None
• Story Points:
2
• Sprint:
TSSW Sprint - Jul 05 - Jul 19, TSSW Sprint - Jul 19 - Aug 02, TSSW Sprint - Aug 02 - Aug 16
• Team:
Telescope and Site
• Urgent?:
No

#### Description

ts_sal includes support for two data types (at least) that we aren't using and don't appear to be necessary:

• char: this is an alias for "string" and is very confusing to me because it sounds like a single 8-bit int (the C definition) instead of a string. It is not used (except in Test).
• octet: it's not being used (except in Test). Do we need it?

I think all the remaining types I know about are used and are fairly self-explanatory.

Would it be practical to remove support for either or both of these? Clearly it is not a high priority and it will be slightly disruptive because it will require minor changes to Test XML and unit tests in ts_sal and ts_salobj (which I am happy to do).

Also: does ts_sal support "unsigned long long" and if not, would that be easy to add? It would be useful for long bitmasks. It's not a big deal because "long long" works, but unsigned is a more natural choice for bitmasks.

#### Attachments

1. Test_Telemetry.xml.char
5 kB
2. Test_Telemetry.xml.octet
5 kB

#### Activity

Hide
Dave Mills added a comment -

char and octet have been removed as vaild types in the XML.
Note that "octet" is the IDL equivalent of "byte or unsigned 8-bit"
so it will still appear in the IDL.

Show
Dave Mills added a comment - char and octet have been removed as vaild types in the XML. Note that "octet" is the IDL equivalent of "byte or unsigned 8-bit" so it will still appear in the IDL.
Hide
Dave Mills added a comment -

Tested using attached XML's

rfactory@localhost:~/lsst/test$salgenerator Test validate SAL_WORK_DIR=/home/rfactory/lsst/test6.11.1 argv = Test validate SAL generator - 6.0.0 checking Test checking validate XMLVERSION = 9.1.1 Processing Test Add Generic Commands and Events Translating Test_scalars **************************************************************** **************************************************************** ERROR - Missing or invalid IDL_Type in Test_scalars: octet0 **************************************************************** **************************************************************** SAL_WORK_DIR=/home/rfactory/lsst/test6.11.1 argv = Test validate SAL generator - 6.0.0 checking Test checking validate XMLVERSION = 9.1.1 Processing Test Add Generic Commands and Events Translating Test_scalars **************************************************************** **************************************************************** ERROR - Missing or invalid IDL_Type in Test_scalars: char0 **************************************************************** **************************************************************** Show Dave Mills added a comment - Tested using attached XML's rfactory@localhost:~/lsst/test$ salgenerator Test validate SAL_WORK_DIR=/home/rfactory/lsst/test6.11.1 argv = Test validate SAL generator - 6.0.0 checking Test checking validate XMLVERSION = 9.1.1 Processing Test Add Generic Commands and Events Translating Test_scalars **************************************************************** **************************************************************** ERROR - Missing or invalid IDL_Type in Test_scalars: octet0 **************************************************************** **************************************************************** SAL_WORK_DIR=/home/rfactory/lsst/test6.11.1 argv = Test validate SAL generator - 6.0.0 checking Test checking validate XMLVERSION = 9.1.1 Processing Test Add Generic Commands and Events Translating Test_scalars **************************************************************** **************************************************************** ERROR - Missing or invalid IDL_Type in Test_scalars: char0 **************************************************************** ****************************************************************
Hide
Dave Mills added a comment -

Removed in latest SAL 6 updates. See test outputs here.

Show
Dave Mills added a comment - Removed in latest SAL 6 updates. See test outputs here.
Hide
Rob Bovill added a comment -

The char and octet data-types have been removed.  XML will need to be updated accordingly or tests will break.

Show
Rob Bovill added a comment - The char and octet data-types have been removed.  XML will need to be updated accordingly or tests will break.
Hide
Russell Owen added a comment -

I think it will suffice to release ts_xml 9.2 before we release this change in ts_sal.

The only use of char and octet that I know of in ts_xml 9.1 is in the Test SAL component. I removed those fields July 9, in DM-31017.

Show
Russell Owen added a comment - I think it will suffice to release ts_xml 9.2 before we release this change in ts_sal. The only use of char and octet that I know of in ts_xml 9.1 is in the Test SAL component. I removed those fields July 9, in DM-31017 .

#### People

Assignee:
Dave Mills
Reporter:
Russell Owen
Reviewers:
Rob Bovill
Watchers:
Dave Mills, Rob Bovill, Russell Owen, Tiago Ribeiro, Wouter van Reeven