Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-29795

Add meas_extensions_trailedSources to lsst_distrib

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Story Points:
      21
    • Epic Link:
    • Sprint:
      AP S21-5 (April), AP S21-6 (May)
    • Team:
      Alert Production
    • Urgent?:
      No

      Description

      Implement trailed sources measurement extension from RFC-768.

        Attachments

          Issue Links

            Activity

            Hide
            cmorrison Chris Morrison [X] (Inactive) added a comment -

            Hey Krzysztof Findeisen when I build the code against the latest weekly I get a bunch of compiler warnings regarding deprecation of Filter amongst others. Wanted to make sure you had seen those and confirmed that they were unrelated to the code under reviewer here. I assume they are.

            Show
            cmorrison Chris Morrison [X] (Inactive) added a comment - Hey Krzysztof Findeisen when I build the code against the latest weekly I get a bunch of compiler warnings regarding deprecation of Filter amongst others. Wanted to make sure you had seen those and confirmed that they were unrelated to the code under reviewer here. I assume they are.
            Hide
            krzys Krzysztof Findeisen added a comment - - edited

            I assume those are from header files included indirectly through Exposure. None of the code in this package uses Filter.

            Show
            krzys Krzysztof Findeisen added a comment - - edited I assume those are from header files included indirectly through Exposure . None of the code in this package uses Filter .
            Hide
            gkovacs Gabor Kovacs [X] (Inactive) added a comment -

            Please find my comments on github. I did not check whether all the (python) calculation formulas are algorithmically correct.

            Most of my comments are minor style and some docstring related. I think, I have found one problem in the unit test.

            Show
            gkovacs Gabor Kovacs [X] (Inactive) added a comment - Please find my comments on github. I did not check whether all the (python) calculation formulas are algorithmically correct. Most of my comments are minor style and some docstring related. I think, I have found one problem in the unit test.
            Hide
            gkovacs Gabor Kovacs [X] (Inactive) added a comment -

            Zach Langford [X] I'm happy with the update, thank you!

            Show
            gkovacs Gabor Kovacs [X] (Inactive) added a comment - Zach Langford [X] I'm happy with the update, thank you!
            Hide
            langfzac Zach Langford [X] (Inactive) added a comment -

            Hi all, thanks for your comments and thoroughness! Chris Morrison [X] can you confirm that the doc building issues have been addressed?

            Show
            langfzac Zach Langford [X] (Inactive) added a comment - Hi all, thanks for your comments and thoroughness!  Chris Morrison [X]  can you confirm that the doc building issues have been addressed?

              People

              Assignee:
              langfzac Zach Langford [X] (Inactive)
              Reporter:
              langfzac Zach Langford [X] (Inactive)
              Reviewers:
              Chris Morrison
              Watchers:
              Chris Morrison [X] (Inactive), Gabor Kovacs [X] (Inactive), Ian Sullivan, Krzysztof Findeisen, Mario Juric, Zach Langford [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.