Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-2981

polygon masking in CoaddPsf

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw, meas_algorithms
    • Labels:
      None

      Description

      We need to create polygon-based masks of the usable area of the focal plane, persist them with exposure, and include them in coaddition of PSFs and aperture corrections.

      This includes HSC issues HSC-972, HSC-973, HSC-974, HSC-975, HSC-976.

      At least some of this will be blocked by DM-833, which is the port issue for coaddition of aperture corrections.

        Attachments

          Issue Links

          FF-depends on

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-833 implement coaddition for aperture corrections

          • Done
          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. DM-3214 ChebyshevBoundedField should use _ not . as field separators for persistence

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-3243 Include polygon bounds in CoaddPsf logic

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-3259 Define polygon bounds for CCDs based on vignetted regions

          • Done

          Improvement - An improvement or enhancement to an existing feature or task. DM-3198 Reduce danger of circular imports in Python due to afw table persistence

          • Invalid

            Activity

            Ascending order - Click to sort in descending order
            6 older comments
            Hide
            Permalink
            price Paul Price added a comment -

            Looks good. I have just a few minor suggestions that you may or may not want to update:

            • When you have a conflict recorded in the commit message, it's helpful to explain what caused the conflicts and how they were resolved.
            • When you say "Modernize ...", could you explain in the commit message what has changed between ancient and modern times?
            • For "Modernize Polygon.cc's handling of Point fields in afw tables", the added code has trailing whitespace.
            • For "Fix ChebyshevBoundedField's...", your commit message is a bit wide on the last line.
            Show
            price Paul Price added a comment - Looks good. I have just a few minor suggestions that you may or may not want to update: When you have a conflict recorded in the commit message, it's helpful to explain what caused the conflicts and how they were resolved. When you say "Modernize ...", could you explain in the commit message what has changed between ancient and modern times? For "Modernize Polygon.cc's handling of Point fields in afw tables", the added code has trailing whitespace. For "Fix ChebyshevBoundedField's...", your commit message is a bit wide on the last line.
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Thank you, Paul. I did not remember what the merge conflicts were about, so I could not enhance those merge messages, but I clarified the other messages you mentioned and removed all trailing whitespace from several of the files that were part of this ticket. After a successful Jenkins build I merged to master.

            Show
            rowen Russell Owen added a comment - Thank you, Paul. I did not remember what the merge conflicts were about, so I could not enhance those merge messages, but I clarified the other messages you mentioned and removed all trailing whitespace from several of the files that were part of this ticket. After a successful Jenkins build I merged to master.
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Note that (contrary to the description) this did not pull over HSC-974. That will be done in DM-3243.

            Show
            swinbank John Swinbank added a comment - Note that (contrary to the description) this did not pull over HSC-974. That will be done in DM-3243 .
            Hide
            Permalink
            swinbank John Swinbank added a comment - - edited

            Pretty sure this doesn't have HSC-975 or HSC-976 either.

            Show
            swinbank John Swinbank added a comment - - edited Pretty sure this doesn't have HSC-975 or HSC-976 either.
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            On further digging: HSC-975 doesn't apply until we have CoaddBoundedField (or equivalent), which is DM-833. I'll add a note to that issue to indicate that it's required.

            I think we can bring HSC-976 over straight away, though.

            Show
            swinbank John Swinbank added a comment - On further digging: HSC-975 doesn't apply until we have CoaddBoundedField (or equivalent), which is DM-833 . I'll add a note to that issue to indicate that it's required. I think we can bring HSC-976 over straight away, though.

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Paul Price
              Watchers:
              Jim Bosch, John Swinbank, Paul Price, Russell Owen, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.