Jim Bosch added a comment - 27/Nov/15 12:01 PM I've fixed the print usage and didn't see anything else that looked like it needed to be modernized. Since it's too late to do anything to better collate the comments on GitHub on this particular issue, here's the full list of commits that have comments: https://github.com/lsst/ctrl_pool/commit/abf50bfd35a81f40a8b5ff402829c1ca83c86ff9 https://github.com/lsst/ctrl_pool/commit/9d1ef153f528c1eb33056b076933b4d5354c38d7 https://github.com/lsst/ctrl_pool/commit/047f0de5a682ad9e9a6f65ccc7cc296e0a0d4ee7 https://github.com/lsst/ctrl_pool/commit/fc300a3e88e41423bf3168d33a924e4cba4c9202 https://github.com/lsst/ctrl_pool/commit/a78f0f60d1b504ab1fd139d709aba14b3b99eb6f https://github.com/lsst/ctrl_pool/commit/63c6ae3f6db3deff6bbcb38ad87c051fbfa99124 https://github.com/lsst/ctrl_pool/commit/8008440ba7a177d06ca2f2091fd1b7ccc911bd7f https://github.com/lsst/ctrl_pool/commit/8d8842fbaeb35731ababdaadbc9d48ff019a485a https://github.com/lsst/ctrl_pool/commit/617f02cde3eea69b192b30eb1f73f65a73a1b404 I believe I've now addressed everything, and since ctrl_events is a new package and hence all of this is already on master, I'm going to declare it ready to go and close this issue. I've not yet added it to lsst_distrib/repos.yaml and hence CI (as I'd originally planned), but I think it's best to save that for when we start to add code that depends on it, since this code doesn't do anything useful on its own. Thank you, Matias Carrasco Kind [X] and Tim Jenness , for the careful reviews, and to Paul Price for helping me address those comments.

Matias Carrasco Kind [X] (Inactive) added a comment - 27/Nov/15 5:03 PM Sounds good to me, I've read all the responses. Thanks for considering my comments

John Swinbank added a comment - 01/Dec/15 8:15 AM Jim Bosch When you have chance, could you add a few words to the W16 release notes describing the functionality added here? While there's obviously a substantial amount of new code, a couple of sentences and a link to relevant documentation would be better than a comprehensive discussion. (Since the docs are coming in DM-3844 , maybe just add a note to that ticket to add the link to the release notes when it's done.)

John Swinbank added a comment - 20/Jan/16 12:25 PM I added a very short mention of this to the release notes. I didn't find any obvious documentation or explanation of exactly what capabilities have been added here, so do please feel free to correct and/or augment my text.

Jim Bosch added a comment - 20/Jan/16 1:02 PM I think what you've said is probably sufficient for this package; what we need to make sure is well-documented (both in release notes and elsewhere) are the specific top-level command-line tools we'll be adding that use it.