Details
-
Type:
Improvement
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ts_main_telescope
-
Labels:
-
Story Points:1
-
Epic Link:
-
Sprint:TSSW Sprint - Jun 07 - Jun 21
-
Team:Telescope and Site
Description
Please consider to improve the inPosition event of rotator by using new flags. In the point-to-point movement, use the Flags_pt2ptMoveComplete and Flags_moveSuccess together. In the tracking, use the Flags_trackingSuccess instead of Flags_slew_complete.
The rotator CSC uses the following code right now:
self.evt_inPosition.set_put( |
inPosition=bool( |
server.telemetry.flags_pt2pt_move_complete
|
or server.telemetry.flags_slew_complete |
)
|
)
|
Actually, maybe you could consider that the Flags_pt2ptMoveComplete may not be needed. It is an Simulink event that intentionally lasts for 1 second (this explains the result in the Simulink simulation and bug reported by Sandrine). This signal will be covered by the Flags_moveSuccess.
Pull request: https://github.com/lsst-ts/ts_mtrotator/pull/46