Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-29832

Improve the inPosition Event of Rotator by Using New Flags

    XMLWordPrintable

    Details

      Description

      Please consider to improve the inPosition event of rotator by using new flags. In the point-to-point movement, use the Flags_pt2ptMoveComplete and Flags_moveSuccess together. In the tracking, use the Flags_trackingSuccess instead of Flags_slew_complete.

      The rotator CSC uses the following code right now:

              self.evt_inPosition.set_put(
                  inPosition=bool(
                      server.telemetry.flags_pt2pt_move_complete
                      or server.telemetry.flags_slew_complete
                  )
              )
      

      Actually, maybe you could consider that the Flags_pt2ptMoveComplete may not be needed. It is an Simulink event that intentionally lasts for 1 second (this explains the result in the Simulink simulation and bug reported by Sandrine). This signal will be covered by the Flags_moveSuccess.

        Attachments

          Issue Links

            Activity

            Hide
            rowen Russell Owen added a comment -
            Show
            rowen Russell Owen added a comment - Pull request: https://github.com/lsst-ts/ts_mtrotator/pull/46
            Hide
            ttsai Te-Wei Tsai added a comment -

            Please consider to use the Flags_trackingSuccess in the tracking. In addition, please help to fix the failed Jenkins test. Thanks!

            Show
            ttsai Te-Wei Tsai added a comment - Please consider to use the Flags_trackingSuccess in the tracking. In addition, please help to fix the failed Jenkins test. Thanks!
            Hide
            rowen Russell Owen added a comment - - edited

            I made that fix (thank you for catching that problem) and also:

            • Fixed a problem with Jenkinsfile (it was not installing ts_tcpip): thanks to Wouter van Reeven for help with that.
            • Fixed made a unit test more robust, fixing DM-30374

            Released as v0.15.1

            Show
            rowen Russell Owen added a comment - - edited I made that fix (thank you for catching that problem) and also: Fixed a problem with Jenkinsfile (it was not installing ts_tcpip): thanks to Wouter van Reeven for help with that. Fixed made a unit test more robust, fixing DM-30374 Released as v0.15.1

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              ttsai Te-Wei Tsai
              Reviewers:
              Te-Wei Tsai
              Watchers:
              Russell Owen, Te-Wei Tsai
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.