Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-29843

Fix gain variance in segmentation.txt for data/comcam

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ts_aos
    • Labels:

      Description

      Fix the variance of gain in `segmentation.txt` for  data/comcam https://github.com/lsst-ts/phosim_syseng4/blob/aos/data/comcam/segmentation.txt .  The update of v1.0.6 of phosim_syseng4  included updating the content of data/comcam/segmentation.txt with values  for gain / read noise from obs_lsst LsstComCam instrument. 

      However, while for `lsst/segmentation.txt` the previous file  version had  in column 9   no variation for gain (number after 1.16821):

      R22_S22_C00 0 2001 0 511 -1 -1 1.16821 0 1000.0 2.0 5.606 0

       

      for `comcam/segmentation.txt` there was a 3% variation (number after 1.4273) 

      R22_S22_C00 0 1999 0 508 1 -1 1.4273 3.0 1000.0 2.0 14.3 3.0

       

      which was preserved in the update. This leads to the gain discrepancy at 3% level between phosim-simulated comcam images and  the content of the obs_lsst mapper . 

      This ticket is to fix the discrepancy by removing the  variation in gain for `comcam/segmentation.txt` (changing in column 9  "3" to "0", like for `lsst/segmentation.txt` above). 

      *Completion criteria*:

      Verify that the gain value in phosim-simulated comcam image is identical to the content of obs_lsst LsstComCam , eg. using the attached code. Currently there is a difference in `gain` as a result of the discrepancy as illustrated by the attached output of running python test_gain.py .

        Attachments

        1. test_gain.py
          0.8 kB
        2. test_gain_output.txt
          1 kB
        3. test_gain_updated.py
          0.8 kB
        4. test_gain_updated_output.txt
          0.9 kB
        5. Screen Shot 2021-04-21 at 8.55.38 PM.png
          Screen Shot 2021-04-21 at 8.55.38 PM.png
          1.22 MB
        6. runIsr.sh
          0.4 kB
        7. testPipeline.yaml
          0.5 kB
        8. starExtra.inst
          23 kB
        9. noBkgnd.cmd
          0.2 kB

          Issue Links

            Activity

            Hide
            ksuberlak Krzysztof Suberlak added a comment -

            The update has been made, and running python test_gain_updated.py yields the desired output test_gain_updated_output.txt. Also , confirmed that the postISR image for lsstComCam looks uniform (image attached). 
            The ISR was performed with the attached pipeline ( testPipeline.yaml ) and the ingest script  runIsr.sh

            Show
            ksuberlak Krzysztof Suberlak added a comment - The update has been made, and running python test_gain_updated.py yields the desired output test_gain_updated_output.txt . Also , confirmed that the postISR image for lsstComCam looks uniform (image attached).  The ISR was performed with the attached pipeline (  testPipeline.yaml ) and the ingest script   runIsr.sh . 
            Hide
            ksuberlak Krzysztof Suberlak added a comment -

            For traceability, attached is the instance catalog starExtra.inst and the physics command file noBkgnd.cmd used to perform the test simulation

            python /project/scichris/aos/phosim_syseng4/phosim.py /project/scichris/aos/ps1_phosim/testBkgnd/starExtra.inst -i comcam -e 1 -c /project/scichris/aos/ps1_phosim/noBkgnd.cmd -p 25 -o /project/scichris/aos/ps1_phosim/testBkgnd/arrowsComCam_fixGain/raw > /project/scichris/aos/ps1_phosim/testBkgnd/arrowsComCam_fixGain/raw/starPhosim.log 2>&1
            

            Show
            ksuberlak Krzysztof Suberlak added a comment - For traceability, attached is the instance catalog  starExtra.inst and the physics command file  noBkgnd.cmd used to perform the test simulation python / project / scichris / aos / phosim_syseng4 / phosim.py / project / scichris / aos / ps1_phosim / testBkgnd / starExtra.inst - i comcam - e 1 - c / project / scichris / aos / ps1_phosim / noBkgnd.cmd - p 25 - o / project / scichris / aos / ps1_phosim / testBkgnd / arrowsComCam_fixGain / raw > / project / scichris / aos / ps1_phosim / testBkgnd / arrowsComCam_fixGain / raw / starPhosim.log 2 >& 1
            Hide
            ttsai Te-Wei Tsai added a comment -

            The update looks good to me.

            Show
            ttsai Te-Wei Tsai added a comment - The update looks good to me.
            Hide
            ksuberlak Krzysztof Suberlak added a comment -

            Incorporated review comments, merged and released as{{ phosim_syseng4}}   v1.0.7  

            Show
            ksuberlak Krzysztof Suberlak added a comment - Incorporated review comments, merged and released as{{ phosim_syseng4}}    v1.0.7  

              People

              Assignee:
              ksuberlak Krzysztof Suberlak
              Reporter:
              ksuberlak Krzysztof Suberlak
              Reviewers:
              Te-Wei Tsai
              Watchers:
              Bryce Kalmbach, Krzysztof Suberlak, Te-Wei Tsai
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.