Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-29872

Fix ATWhiteLight state transitions, use of deprecated commands

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Story Points:
      6
    • Epic Link:
    • Sprint:
      TSSW Sprint - Apr 26 - May 10, TSSW Sprint - May 10 - May 24, TSSW Sprint - May 24 - Jun 07
    • Team:
      Telescope and Site
    • Urgent?:
      No

      Description

      While I was setting WhiteLight up for conda, I added the test_standard_state_transitions test and it failed. It looks like at least one of the problems is that its trying to access the config before the config is loaded. I think this was written before ConfigurableCsc existed so I probably just need to hand that all off to salobj. Also there are a couple deprecation warnings to fix.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-32581 Update ts_ATWhiteLightSource to fix deprecation warnings from salobj

          • Won't Fix

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-30111 ATWhiteLightSource review feedback

          • Invalid

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            cwinslow Colin Winslow [X] (Inactive) added a comment -

            This brings things up to speed a bit for current salobj and python versions. Tests pass, but I don't want to merge until i can try it with the real hardware.

            Show
            cwinslow Colin Winslow [X] (Inactive) added a comment - This brings things up to speed a bit for current salobj and python versions. Tests pass, but I don't want to merge until i can try it with the real hardware.
            Hide
            Permalink
            cwinslow Colin Winslow [X] (Inactive) added a comment -

            https://github.com/lsst-ts/ts_ATWhiteLightSource/pull/11

            Show
            cwinslow Colin Winslow [X] (Inactive) added a comment - https://github.com/lsst-ts/ts_ATWhiteLightSource/pull/11
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Reviewed on github.

            Show
            rowen Russell Owen added a comment - Reviewed on github.

              People

              Assignee:
              cwinslow Colin Winslow [X] (Inactive)
              Reporter:
              cwinslow Colin Winslow [X] (Inactive)
              Reviewers:
              Russell Owen
              Watchers:
              Andy Clements, Colin Winslow [X] (Inactive), Patrick Ingraham, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.