Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-29884

Fix exception in Gen3+applyColorTerms logic branch of jointcal

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: jointcal
    • Labels:
      None

      Description

      When running jointcal on HSC RC2 with doPhotometry=True and doApplyColorTerms=True, I get this exception:

        File "/software/lsstsw/stack_20210415/stack/miniconda3-py38_4.9.2-0.5.0/Linux64/jointcal/21.0.0-14-gc0d6d5c+36dc79dc4c/python/lsst/jointcal/jointcal.py", line 744, in run
      		 
          photometry = self._do_load_refcat_and_fit(associations, defaultFilter, center, radius,
      		 
        File "/software/lsstsw/stack_20210415/stack/miniconda3-py38_4.9.2-0.5.0/Linux64/jointcal/21.0.0-14-gc0d6d5c+36dc79dc4c/python/lsst/jointcal/jointcal.py", line 1229, in _do_load_refcat_and_fit
      		 
          refCat, fluxField = self._load_reference_catalog(refObjLoader, referenceSelector,
      		 
        File "/software/lsstsw/stack_20210415/stack/miniconda3-py38_4.9.2-0.5.0/Linux64/jointcal/21.0.0-14-gc0d6d5c+36dc79dc4c/python/lsst/jointcal/jointcal.py", line 1309, in _load_reference_catalog
      		 
          refCatName = refObjLoader.ref_dataset_name
      		 
      AttributeError: 'ReferenceObjectLoader' object has no attribute 'ref_dataset_name'

      I don't know if this is a configuration problem or another Gen2 vs. Gen3 refcat loader inconsistency. But I'm just going to disable jointcal photometry in Gen3 in the obs_subaru pipeline in the meantime (on DM-29776), so this isn't a super high priority.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-29885 Disable jointcal photometry in HSC via config

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-29776 Attempt complete two-QG HSC RC2 run on w16 on one tract

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            kannawad Arun Kannawadi added a comment -

            Thanks to Nate Lust and John Parejko for helping on my first-ever ticket on jointcal!

            Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/35378/pipeline

            Show
            kannawad Arun Kannawadi added a comment - Thanks to Nate Lust  and John Parejko  for helping on my first-ever ticket on jointcal! Jenkins run:  https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/35378/pipeline
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            We pair coded this, so it's had 3 eyes on it already.

            Show
            Parejkoj John Parejko added a comment - We pair coded this, so it's had 3 eyes on it already.
            Hide
            Permalink
            yusra Yusra AlSayyad added a comment -

            It's a good idea to do a search for the ticket number in the codebase (via github) to see if the ticket number appears in any TODO inline comments: https://github.com/lsst/obs_subaru/blob/master/pipelines/DRP.yaml#L17

            The `applyColorTerms: false` line can be removed now. (Should have been on this ticket, but can be on a new one)

            (DM-29885 to move doPhotometry: false to the configs without breaking the jointcal unit tests is a separate issue)

            Show
            yusra Yusra AlSayyad added a comment - It's a good idea to do a search for the ticket number in the codebase (via github) to see if the ticket number appears in any TODO inline comments: https://github.com/lsst/obs_subaru/blob/master/pipelines/DRP.yaml#L17 The `applyColorTerms: false` line can be removed now. (Should have been on this ticket, but can be on a new one) ( DM-29885 to move doPhotometry: false to the configs without breaking the jointcal unit tests is a separate issue)
            Hide
            Permalink
            kannawad Arun Kannawadi added a comment -

            Ah, sorry we missed that. I set `applyColorTerms: true` and ran jointcal with my local obs_subaru setup. I did not get any warnings and the comments in that file say. I could either make it a note on DM-29885 or happy to open a new ticket and make the change.

            Show
            kannawad Arun Kannawadi added a comment - Ah, sorry we missed that. I set `applyColorTerms: true` and ran jointcal with my local obs_subaru setup. I did not get any warnings and the comments in that file say. I could either make it a note on DM-29885 or happy to open a new ticket and make the change.
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            I'm removing the applyColorTerms: false line on DM-30891, and will adjust the comments referencing this ticket.

            Show
            jbosch Jim Bosch added a comment - I'm removing the applyColorTerms: false line on DM-30891 , and will adjust the comments referencing this ticket.

              People

              Assignee:
              kannawad Arun Kannawadi
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              John Parejko
              Watchers:
              Arun Kannawadi, Jim Bosch, John Parejko, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.