Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-29902

salobj.CscCommander mishandles bool command arguments

    XMLWordPrintable

    Details

    • Story Points:
      0
    • Epic Link:
    • Sprint:
      TSSW Sprint - Apr 26 - May 10
    • Team:
      Telescope and Site
    • Urgent?:
      No

      Description

      salobj.CscCommander tries to use the bool function to handle command arguments, which results the argument always treated as true. Preferably use a dict of values (e.g. 0/f/1/t, but a simpler option is to use bool(int(arg)).

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          rowen Russell Owen added a comment - - edited

          Pull request: https://github.com/lsst-ts/ts_salobj/pull/190

          Show
          rowen Russell Owen added a comment - - edited Pull request: https://github.com/lsst-ts/ts_salobj/pull/190
          Hide
          Permalink
          wvreeven Wouter van Reeven added a comment -

          Reviewed on GitHub. Looks good to me.

          Show
          wvreeven Wouter van Reeven added a comment - Reviewed on GitHub. Looks good to me.
          Hide
          Permalink
          rowen Russell Owen added a comment -

          Released ts_salobj v6.3.5

          Show
          rowen Russell Owen added a comment - Released ts_salobj v6.3.5

            People

            Assignee:
            rowen Russell Owen
            Reporter:
            rowen Russell Owen
            Reviewers:
            Wouter van Reeven
            Watchers:
            Russell Owen, Wouter van Reeven
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.