Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-29944

Add some narrow-band filters to skymap's tract+patch+band data ID packers

    XMLWordPrintable

    Details

    • Story Points:
      0.5
    • Epic Link:
    • Team:
      Data Release Production
    • Urgent?:
      No

      Description

      This will not be a pretty fix, but will be a necessary one for HSC RC2 Gen3 processing with w18.  I will open a ticket to find a better solution later.

        Attachments

          Issue Links

          is duplicated by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-30279 "NotImplementedError: band 'N921' not supported by this ID packer" prevents coadd measurement

          • Invalid
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-29776 Attempt complete two-QG HSC RC2 run on w16 on one tract

          • Done

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-785 Move data ID -> integer packing state and logic out of butler

          • Implemented

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            This is a blocker on running HSC NB921 data in Gen3 (or any other narrow-band filter).  But having done the work (the fix is on the branch), I think the potential implications of this change (I think it'll change some source IDs) make it unsafe to try to squeeze into the weekly tonight.  I'm going to save it for the next one; we can skip coadd processing of NB921 in w18 and still learn a lot.

            Show
            jbosch Jim Bosch added a comment - This is a blocker on running HSC NB921 data in Gen3 (or any other narrow-band filter).  But having done the work (the fix is on the branch), I think the potential implications of this change (I think it'll change some source IDs) make it unsafe to try to squeeze into the weekly tonight.  I'm going to save it for the next one; we can skip coadd processing of NB921 in w18 and still learn a lot.
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Thanks for volunteering!  PR is https://github.com/lsst/skymap/pull/50/files

            Show
            jbosch Jim Bosch added a comment - Thanks for volunteering!  PR is https://github.com/lsst/skymap/pull/50/files
            Hide
            Permalink
            fred3m Fred Moolekamp added a comment -

            No problem. Assuming the filter names are correct this is good to go (just checking because I always see it written NB921 etc. but the ticket implements N921 etc.).

            Show
            fred3m Fred Moolekamp added a comment - No problem. Assuming the filter names are correct this is good to go (just checking because I always see it written NB921 etc. but the ticket implements N921 etc.).
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Yup, for historical and probably arbitrary reasons, the "band" values are Nxxx and the "physical_filter" values are NBxxx.

            Show
            jbosch Jim Bosch added a comment - Yup, for historical and probably arbitrary reasons, the "band" values are Nxxx and the "physical_filter" values are NBxxx.

              People

              Assignee:
              jbosch Jim Bosch
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Fred Moolekamp
              Watchers:
              Fred Moolekamp, Jim Bosch
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.