Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-29955

Add ExposureInfo id getter (replacement for VisitInfo.getExposureId())

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Story Points:
      24
    • Epic Link:
    • Sprint:
      AP F21-4 (September), AP F21-5 (October)
    • Team:
      Alert Production
    • Urgent?:
      No

      Description

      Before deprecating and removing VisitInfo.getExposureId(), we need a replacement in ExposureInfo. It will contain the same id as the one currently in VisitInfo. How to populate it may be a question, since VisitInfo gets populated by ObservationInfo; can we do something similar to get exposureId into ExposureInfo for raws?

      I've started a #dm-naming-things thread to figure out what to call the new id(s).

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-13943 Deprecate VisitInfo.getExposureId()

          • Done
          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-13944 add id to VisitInfo

          • Done
          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-459 Remove exposureId from VisitInfo and add visitId

          • Implemented
          is triggering

          Bug - A problem which impairs or prevents the functions of the product. DM-32315 DM-29955 breaks ci_hsc_gen2

          • Done
          relates to

          Bug - A problem which impairs or prevents the functions of the product. DM-32414 Exposure ID Gen 3 disassembled component broken

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            ObservationInfo can populate this in the gen3 raw formatter just like VisitInfo is formed or in the formatter it can simply trust the butler and use the exposure that comes from the dataId. After that it should propagate on its own. I assume we are talking about exposure_id here and not detector_exposure_id?

            Show
            tjenness Tim Jenness added a comment - ObservationInfo can populate this in the gen3 raw formatter just like VisitInfo is formed or in the formatter it can simply trust the butler and use the exposure that comes from the dataId. After that it should propagate on its own. I assume we are talking about exposure_id here and not detector_exposure_id?
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            This is to be exactly the same as the existing visitInfo.exposureId, which is the detector-level identifier and is attached to each afw Exposure. I could call it getDetectorExposureId() or getSensorExposureId()? I don't know where your version of the "exposure id" (the full focal plane identifier of a single shutter operation) should live.

            Show
            Parejkoj John Parejko added a comment - This is to be exactly the same as the existing visitInfo.exposureId , which is the detector-level identifier and is attached to each afw Exposure. I could call it getDetectorExposureId() or getSensorExposureId() ? I don't know where your version of the "exposure id" (the full focal plane identifier of a single shutter operation) should live.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Post DM-19344 note: the full focal plane identifier that lives in VisitInfo is just id (with a python property). The detector+exposure identifier that will live in ExposureInfo will be exposureInfo.id.

            Show
            Parejkoj John Parejko added a comment - Post DM-19344 note: the full focal plane identifier that lives in VisitInfo is just id (with a python property). The detector+exposure identifier that will live in ExposureInfo will be exposureInfo.id .
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            I'm claiming this so that I can implement DM-13943.

            Show
            krzys Krzysztof Findeisen added a comment - I'm claiming this so that I can implement DM-13943 .
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment - - edited

            Hi John Parejko, can you review this? There are 10 PRs (including afw#613, which is not shown in Jira), for a total of 240 lines.

            Show
            krzys Krzysztof Findeisen added a comment - - edited Hi John Parejko , can you review this? There are 10 PRs (including afw#613 , which is not shown in Jira), for a total of 240 lines.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Thank you for taking this on! In the end, it didn't look as complicated as I'd feared, and I'm glad you thought about the question of explicitly keeping the value self-consistent with VisitInfo.exposureId.

            A handful of comments, mostly on the afw PR. They should be easy to sort out.

            Show
            Parejkoj John Parejko added a comment - Thank you for taking this on! In the end, it didn't look as complicated as I'd feared, and I'm glad you thought about the question of explicitly keeping the value self-consistent with VisitInfo.exposureId . A handful of comments, mostly on the afw PR. They should be easy to sort out.

              People

              Assignee:
              krzys Krzysztof Findeisen
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              John Parejko
              Watchers:
              Ian Sullivan, Jim Bosch, John Parejko, Krzysztof Findeisen, Tim Jenness, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.