Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-29955

Add ExposureInfo id getter (replacement for VisitInfo.getExposureId())

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • afw
    • 24
    • AP F21-4 (September), AP F21-5 (October)
    • Alert Production
    • No

    Description

      Before deprecating and removing VisitInfo.getExposureId(), we need a replacement in ExposureInfo. It will contain the same id as the one currently in VisitInfo. How to populate it may be a question, since VisitInfo gets populated by ObservationInfo; can we do something similar to get exposureId into ExposureInfo for raws?

      I've started a #dm-naming-things thread to figure out what to call the new id(s).

      Attachments

        Issue Links

          Activity

            tjenness Tim Jenness added a comment -

            ObservationInfo can populate this in the gen3 raw formatter just like VisitInfo is formed or in the formatter it can simply trust the butler and use the exposure that comes from the dataId. After that it should propagate on its own. I assume we are talking about exposure_id here and not detector_exposure_id?

            tjenness Tim Jenness added a comment - ObservationInfo can populate this in the gen3 raw formatter just like VisitInfo is formed or in the formatter it can simply trust the butler and use the exposure that comes from the dataId. After that it should propagate on its own. I assume we are talking about exposure_id here and not detector_exposure_id?
            Parejkoj John Parejko added a comment -

            This is to be exactly the same as the existing visitInfo.exposureId, which is the detector-level identifier and is attached to each afw Exposure. I could call it getDetectorExposureId() or getSensorExposureId()? I don't know where your version of the "exposure id" (the full focal plane identifier of a single shutter operation) should live.

            Parejkoj John Parejko added a comment - This is to be exactly the same as the existing visitInfo.exposureId , which is the detector-level identifier and is attached to each afw Exposure. I could call it getDetectorExposureId() or getSensorExposureId() ? I don't know where your version of the "exposure id" (the full focal plane identifier of a single shutter operation) should live.

            Post DM-19344 note: the full focal plane identifier that lives in VisitInfo is just id (with a python property). The detector+exposure identifier that will live in ExposureInfo will be exposureInfo.id.

            Parejkoj John Parejko added a comment - Post DM-19344 note: the full focal plane identifier that lives in VisitInfo is just id (with a python property). The detector+exposure identifier that will live in ExposureInfo will be exposureInfo.id .

            I'm claiming this so that I can implement DM-13943.

            krzys Krzysztof Findeisen added a comment - I'm claiming this so that I can implement DM-13943 .
            krzys Krzysztof Findeisen added a comment - - edited

            Hi Parejkoj, can you review this? There are 10 PRs (including afw#613, which is not shown in Jira), for a total of 240 lines.

            krzys Krzysztof Findeisen added a comment - - edited Hi Parejkoj , can you review this? There are 10 PRs (including afw#613 , which is not shown in Jira), for a total of 240 lines.

            Thank you for taking this on! In the end, it didn't look as complicated as I'd feared, and I'm glad you thought about the question of explicitly keeping the value self-consistent with VisitInfo.exposureId.

            A handful of comments, mostly on the afw PR. They should be easy to sort out.

            Parejkoj John Parejko added a comment - Thank you for taking this on! In the end, it didn't look as complicated as I'd feared, and I'm glad you thought about the question of explicitly keeping the value self-consistent with VisitInfo.exposureId . A handful of comments, mostly on the afw PR. They should be easy to sort out.

            People

              krzys Krzysztof Findeisen
              Parejkoj John Parejko
              John Parejko
              Ian Sullivan, Jim Bosch, John Parejko, Krzysztof Findeisen, Tim Jenness, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.