Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-29989

Update deprecated decorator to include version

    XMLWordPrintable

    Details

    • Story Points:
      2
    • Epic Link:
    • Sprint:
      DRP S21b
    • Team:
      Data Release Production
    • Urgent?:
      No

      Description

      The pipe_analysis scripts are currently failing with:

      ValueError: 'version' argument is required in Sphinx directives

       This is because the deprecation decorators added to two functors in utils.py on DM-26329.

      I am also going to take the opportunity to disable the plots that use the values computed by these deprecated functors. They were specifically requested on DM-12802, but are no longer desired.

        Attachments

          Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. DM-26329 Remove the use of Regaussianization quantities for star-PSF comparison

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-12802 Add shape measurements to coadd comparison.

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            lauren Lauren MacArthur added a comment -

            Ok, this should do it. I've tested all five scripts on at least one dataId. They ran fine and the offending plots, namely

            visit:
            		 
            plot-v1228-e1ResidsHsmRegauss-psfMagHist.png
            		 
            plot-v1228-e1ResidsHsmRegauss-sky-stars.png
            		 
            plot-v1228-e2ResidsHsmRegauss-psfMagHist.png
            		 
            plot-v1228-e2ResidsHsmRegauss-sky-stars.png
            		 
             
            		 
            coadd:
            		 
            plot-t9813-HSC-I-e1ResidsHsmRegauss_unforced-psfMagHist.png
            		 
            plot-t9813-HSC-I-e1ResidsHsmRegauss_unforced-sky-stars.png
            		 
            plot-t9813-HSC-I-e2ResidsHsmRegauss_unforced-psfMagHist.png
            		 
            plot-t9813-HSC-I-e2ResidsHsmRegauss_unforced-sky-stars.png

            are no longer created.

            Could you give this branch a go when you get a chance?

            Show
            lauren Lauren MacArthur added a comment - Ok, this should do it. I've tested all five scripts on at least one dataId. They ran fine and the offending plots, namely visit: plot - v1228 - e1ResidsHsmRegauss - psfMagHist.png plot - v1228 - e1ResidsHsmRegauss - sky - stars.png plot - v1228 - e2ResidsHsmRegauss - psfMagHist.png plot - v1228 - e2ResidsHsmRegauss - sky - stars.png   coadd: plot - t9813 - HSC - I - e1ResidsHsmRegauss_unforced - psfMagHist.png plot - t9813 - HSC - I - e1ResidsHsmRegauss_unforced - sky - stars.png plot - t9813 - HSC - I - e2ResidsHsmRegauss_unforced - psfMagHist.png plot - t9813 - HSC - I - e2ResidsHsmRegauss_unforced - sky - stars.png are no longer created. Could you give this branch a go when you get a chance?
            Hide
            Permalink
            lauren Lauren MacArthur added a comment -

            PR is here.

            Show
            lauren Lauren MacArthur added a comment - PR is here .
            Hide
            Permalink
            kannawad Arun Kannawadi added a comment -

            Oops, that's on me. I didn't know that we had to give the version number for the science pipelines release. The changes in the PR look good (not an official reviewer_

            Show
            kannawad Arun Kannawadi added a comment - Oops, that's on me. I didn't know that we had to give the version number for the science pipelines release. The changes in the PR look good (not an official reviewer_
            Hide
            Permalink
            lauren Lauren MacArthur added a comment -

            Cool, thanks Arun.  I'll wait for Eric to confirm the scripts now run ok (and marks as reviewed) before merging.

            Show
            lauren Lauren MacArthur added a comment - Cool, thanks Arun.  I'll wait for Eric to confirm the scripts now run ok (and marks as reviewed) before merging.
            Hide
            Permalink
            emorganson Eric Morganson [X] (Inactive) added a comment - - edited

            Sorry for the delay. Had problems with FGCM that I hopefully just fixed. Can confirm that
            visitAnalysis.py --help
            now runs appropriately. And I should be able to run it for real either tonight or tomorrow.

            Show
            emorganson Eric Morganson [X] (Inactive) added a comment - - edited Sorry for the delay. Had problems with FGCM that I hopefully just fixed. Can confirm that visitAnalysis.py --help now runs appropriately. And I should be able to run it for real either tonight or tomorrow.
            Hide
            Permalink
            lauren Lauren MacArthur added a comment -

            Hey Eric,

            It looks like all the scripts ran ok (as evidenced by the plots in https://lsst.ncsa.illinois.edu/~emorgan2/w_2021_18_qaplots/). If this is indeed the case, would you mind hitting the Review Complete button & I'll merge this to master?

            Show
            lauren Lauren MacArthur added a comment - Hey Eric, It looks like all the scripts ran ok (as evidenced by the plots in  https://lsst.ncsa.illinois.edu/~emorgan2/w_2021_18_qaplots/ ). If this is indeed the case, would you mind hitting the Review Complete button & I'll merge this to master?
            Hide
            Permalink
            emorganson Eric Morganson [X] (Inactive) added a comment -

            Plots now work. Thansk.

            Show
            emorganson Eric Morganson [X] (Inactive) added a comment - Plots now work. Thansk.
            Hide
            Permalink
            lauren Lauren MacArthur added a comment -

            Thanks!  Merged to master.

            Show
            lauren Lauren MacArthur added a comment - Thanks!  Merged to master.

              People

              Assignee:
              lauren Lauren MacArthur
              Reporter:
              lauren Lauren MacArthur
              Reviewers:
              Eric Morganson [X] (Inactive)
              Watchers:
              Arun Kannawadi, Clare Saunders, Eric Morganson [X] (Inactive), Lauren MacArthur, Sophie Reed
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.