Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-30030

Make calibration source selection consistent between gen2 and gen3 middleware - part deux

    XMLWordPrintable

Details

    • 8
    • DRP S21b
    • Data Release Production
    • No

    Description

      Analysis on DM-29819 revealed some residual issues related to loading of reference catalogs. Specifically, because of an inconsistent setting of the config parameter:
      calibrate.astromRefObjLoader.pixelMargin
      and the
      computeVisitRegions["single-raw-wcs"].padding
      of defineVisits.py
      there are cases where slightly different reference catalogs are getting loaded in gen2 vs. gen3, I think the logic should be that pixelMargin <= computeVisitRegions["single-raw-wcs"].padding. However, as it stands, the default for pixelMargin is 300 and, in cases we were unlucky not to encounter in ci_hsc, this can lead to a smaller loaded region in gen3 because of the smaller visit padded definition (i.e. if a shard edge lies close to the padded visit edge). See DM-29819 for an example.

      While I'm not sure it will be possible to check the above condition in a config "validation", I think we should at least ensure it is satisfied for the stack defaults as well as any overrides in individual obs_ packages.

      Attachments

        1. allRefCats_19662_1_newPad.png
          allRefCats_19662_1_newPad.png
          359 kB
        2. allRefCats_19662_1_origPad.png
          allRefCats_19662_1_origPad.png
          370 kB
        3. allRefCats_257768_0_newPad.png
          allRefCats_257768_0_newPad.png
          411 kB
        4. allRefCats_257768_0_origPad.png
          allRefCats_257768_0_origPad.png
          417 kB
        5. allRefCats_289408_1_newPad.png
          allRefCats_289408_1_newPad.png
          414 kB
        6. allRefCats_289408_1_origPad.png
          allRefCats_289408_1_origPad.png
          424 kB
        7. fixedGen3_19662_1.png
          fixedGen3_19662_1.png
          482 kB
        8. gen2gen3trimmedRefCats.png
          gen2gen3trimmedRefCats.png
          837 kB
        9. gen2gen3trimmedRefCatsFix.png
          gen2gen3trimmedRefCatsFix.png
          738 kB
        10. gen3RefLoadingIssue.png
          gen3RefLoadingIssue.png
          655 kB
        11. trimmedInput.png
          trimmedInput.png
          152 kB
        12. wcsRoundTrip.png
          wcsRoundTrip.png
          180 kB
        13. wcsRoundTripZoom.png
          wcsRoundTripZoom.png
          393 kB

        Issue Links

          Activity

            lauren Lauren MacArthur created issue -
            lauren Lauren MacArthur made changes -
            Field Original Value New Value
            Link This issue relates to DM-28936 [ DM-28936 ]
            lauren Lauren MacArthur made changes -
            Link This issue relates to DM-24024 [ DM-24024 ]
            lauren Lauren MacArthur made changes -
            Link This issue relates to DM-29819 [ DM-29819 ]
            lauren Lauren MacArthur made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            lauren Lauren MacArthur made changes -
            Attachment gen2gen3trimmedRefCats.png [ 49453 ]
            lauren Lauren MacArthur made changes -
            Attachment gen2gen3trimmedRefCatsFix.png [ 49454 ]
            lauren Lauren MacArthur made changes -
            Attachment gen3RefLoadingIssue.png [ 49546 ]
            erykoff Eli Rykoff made changes -
            Assignee Lauren MacArthur [ lauren ] Eli Rykoff [ erykoff ]
            lauren Lauren MacArthur made changes -
            Attachment wcsRoundTrip.png [ 49554 ]
            lauren Lauren MacArthur made changes -
            Attachment wcsRoundTripZoom.png [ 49555 ]
            lauren Lauren MacArthur made changes -
            Attachment trimmedInput.png [ 49556 ]
            lauren Lauren MacArthur made changes -
            Assignee Eli Rykoff [ erykoff ] Lauren MacArthur [ lauren ]
            lauren Lauren MacArthur made changes -
            Attachment fixedGen3_19662_1.png [ 49583 ]
            lauren Lauren MacArthur made changes -
            Reviewers Jim Bosch [ jbosch ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            lauren Lauren MacArthur made changes -
            Remote Link This issue links to "Page (Confluence)" [ 28464 ]
            jbosch Jim Bosch made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            lauren Lauren MacArthur made changes -
            Attachment allRefCats_19662_1_origPad.png [ 49704 ]
            lauren Lauren MacArthur made changes -
            Attachment allRefCats_257768_0_origPad.png [ 49705 ]
            lauren Lauren MacArthur made changes -
            Attachment allRefCats_289408_1_origPad.png [ 49706 ]
            lauren Lauren MacArthur made changes -
            Attachment allRefCats_19662_1_newPad.png [ 49707 ]
            lauren Lauren MacArthur made changes -
            Attachment allRefCats_257768_0_newPad.png [ 49708 ]
            lauren Lauren MacArthur made changes -
            Attachment allRefCats_289408_1_newPad.png [ 49709 ]
            lauren Lauren MacArthur made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            lauren Lauren MacArthur made changes -
            Story Points 8
            krzys Krzysztof Findeisen made changes -
            Link This issue relates to DM-30296 [ DM-30296 ]

            People

              lauren Lauren MacArthur
              lauren Lauren MacArthur
              Jim Bosch
              Eli Rykoff, Jim Bosch, John Parejko, Kian-Tat Lim, Lauren MacArthur
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.