Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-30054

Generalize fgcmLoadReferenceCatalog for broader use.

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: fgcmcal, meas_algorithms
    • Labels:
      None

      Description

      The task FgcmLoadReferenceCatalogTask is a layer on top of LoadIndexedReferenceObjectsTask that provides these additional features:

      • Loads multiple reference filters at once.
      • Integrated referenceSelector
      • Applies color terms (if configured)
      • Ability to select by healpix number (on top of loadSkyCircle)
      • Returns the catalog as a convenient numpy record array.

      After discussions with Keith Bechtol I realized that with modest modification this will be ideal for use in faro. This ticket will move this task from fgcmcal to meas_algorithms, rename everything to remove "fgcm" name references, and add additional features including the option to return pandas dataframes.

      This ticket does not solve the question of how to update the underlying LoadIndexedReferenceObjectsTask to be a better gen3 citizen.

        Attachments

          Issue Links

            Activity

            Hide
            lskelvin Lee Kelvin added a comment -

            Thanks Eli, this is a very nicely written ticket, and I took away a lot from going through it. This ticket adds the LoadReferenceCatalogTask into meas_algorithms, implementing several useful features for general use. The unit tests are comprehensive, and very nicely written. I've added minor comments on GitHub which I hope are useful. Assuming Jenkins doesn't complain, then this looks good to merge to me.

            Show
            lskelvin Lee Kelvin added a comment - Thanks Eli, this is a very nicely written ticket, and I took away a lot from going through it. This ticket adds the LoadReferenceCatalogTask into meas_algorithms , implementing several useful features for general use. The unit tests are comprehensive, and very nicely written. I've added minor comments on GitHub which I hope are useful. Assuming Jenkins doesn't complain, then this looks good to merge to me.
            Show
            erykoff Eli Rykoff added a comment - Jenkins is green: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/34455/pipeline/

              People

              Assignee:
              erykoff Eli Rykoff
              Reporter:
              erykoff Eli Rykoff
              Reviewers:
              Lee Kelvin
              Watchers:
              Eli Rykoff, John Parejko, Keith Bechtol, Lauren MacArthur, Lee Kelvin
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.