Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: fgcmcal, meas_algorithms
-
Labels:None
-
Story Points:2
-
Epic Link:
-
Team:Data Release Production
-
Urgent?:No
Description
The task FgcmLoadReferenceCatalogTask is a layer on top of LoadIndexedReferenceObjectsTask that provides these additional features:
- Loads multiple reference filters at once.
- Integrated referenceSelector
- Applies color terms (if configured)
- Ability to select by healpix number (on top of loadSkyCircle)
- Returns the catalog as a convenient numpy record array.
After discussions with Keith Bechtol I realized that with modest modification this will be ideal for use in faro. This ticket will move this task from fgcmcal to meas_algorithms, rename everything to remove "fgcm" name references, and add additional features including the option to return pandas dataframes.
This ticket does not solve the question of how to update the underlying LoadIndexedReferenceObjectsTask to be a better gen3 citizen.
Attachments
Issue Links
Activity
| Field | Original Value | New Value |
|---|---|---|
| Remote Link | This issue links to "Page (Confluence)" [ 28430 ] |
| Status | To Do [ 10001 ] | In Progress [ 3 ] |
| Remote Link | This issue links to "Page (Confluence)" [ 28603 ] |
| Watchers | Eli Rykoff, Keith Bechtol [ Eli Rykoff, Keith Bechtol ] | Eli Rykoff, Keith Bechtol, Lauren MacArthur [ Eli Rykoff, Keith Bechtol, Lauren MacArthur ] |
| Reviewers | Lee Kelvin [ lskelvin ] | |
| Status | In Progress [ 3 ] | In Review [ 10004 ] |
| Remote Link | This issue links to "Page (Confluence)" [ 28800 ] |
| Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
| Resolution | Done [ 10000 ] | |
| Status | Reviewed [ 10101 ] | Done [ 10002 ] |
| Remote Link | This issue links to "Page (Confluence)" [ 29161 ] |
| Remote Link | This issue links to "Page (Confluence)" [ 29161 ] |
Thanks Eli, this is a very nicely written ticket, and I took away a lot from going through it. This ticket adds the LoadReferenceCatalogTask into meas_algorithms, implementing several useful features for general use. The unit tests are comprehensive, and very nicely written. I've added minor comments on GitHub which I hope are useful. Assuming Jenkins doesn't complain, then this looks good to merge to me.