Details
-
Type:
Bug
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ts_aos
-
Labels:
-
Story Points:2
-
Epic Link:
-
Team:Telescope and Site
-
Urgent?:No
Description
The DM-29702 aimed to fix the rotation angle offset, and while it seemed arbitrary whether 90 +/- ROTANG is chosen, it turns out to have introduced a bug as a result of poor choice of test angle.
This ticket is to correct it, and make the change as 90 - ROTANG
Also, update ts_wep test files, to correct changes introduced in v1.6.2
Completion criteria:
Verify that when using non-zero rotation angle (eg. rotskypos 30) the repackager correctly creates the ROTANG. One way to test that is if together with primary header aliases ROTPA and ROTSTART result in butler making the exposure-attached wcs that allows to translate the instance catalog to ccd pixel positions with correct orientation, as in the image below (code attached)
test_wcs.py
The code below can be used to reproduce the image:
ssh lsst-devl03
|
source "/software/lsstsw/stack/loadLSST.bash" |
setup lsst_distrib
|
setup -k -r /project/scichris/aos/phosim_utils/
|
|
|
python /project/scichris/aos/phosim_syseng4/phosim.py /project/scichris/aos/ps1_phosim/test_rotang/stars_comCam_PS1_high_focal_rotskypos_30.inst -i comcam -e 1 -c /project/scichris/aos/ps1_phosim/noBkgnd.cmd -p 24 -w /project/scichris/aos/ps1_phosim/test_rotang/rotskypos -s R22_S01 -o /project/scichris/aos/ps1_phosim/test_rotang/rotskypos/raw > /project/scichris/aos/ps1_phosim/test_rotang/rotskypos/starPhoSim.log 2>&1 |
|
|
phosim_repackager.py /project/scichris/aos/ps1_phosim/test_rotang/rotskypos/raw --out_dir /project/scichris/aos/ps1_phosim/test_rotang/rotskypos/repackaged --inst comcam
|
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Description |
The This ticket is to correct it, and make the change as 90 - ROTANG Also, update ts_wep test files, to correct changes introduced in v1.6.2 *Completion criteria:* Verify that when using non-zero rotation angle (eg. rotskypos 30) the repackager correctly creates the ROTANG, and that primary header aliases for ROTANG - ROTPA and ROTSTART, result in butler making the exposure-attached wcs that allows to translate the instance catalog to ccd pixel positions with correct orientation, as in the image below (code attached) [^test_wcs.py] !image-2021-05-07-15-20-42-122.png|width=410,height=396! The code below can be used to reproduce the image: {code:java} ssh lsst-devl03 source "/software/lsstsw/stack/loadLSST.bash" setup lsst_distrib setup -k -r /project/scichris/aos/phosim_utils/ python /project/scichris/aos/phosim_syseng4/phosim.py /project/scichris/aos/ps1_phosim/test_rotang/stars_comCam_PS1_high_focal_rotskypos_30.inst -i comcam -e 1 -c /project/scichris/aos/ps1_phosim/noBkgnd.cmd -p 24 -w /project/scichris/aos/ps1_phosim/test_rotang/rotskypos -s R22_S01 -o /project/scichris/aos/ps1_phosim/test_rotang/rotskypos/raw > /project/scichris/aos/ps1_phosim/test_rotang/rotskypos/starPhoSim.log 2>&1 phosim_repackager.py /project/scichris/aos/ps1_phosim/test_rotang/rotskypos/raw --out_dir /project/scichris/aos/ps1_phosim/test_rotang/rotskypos/repackaged --inst comcam {code} |
The This ticket is to correct it, and make the change as 90 - ROTANG Also, update ts_wep test files, to correct changes introduced in v1.6.2 *Completion criteria:* Verify that when using non-zero rotation angle (eg. rotskypos 30) the repackager correctly creates the ROTANG. One way to test that is if together with primary header aliases ROTPA and ROTSTART result in butler making the exposure-attached wcs that allows to translate the instance catalog to ccd pixel positions with correct orientation, as in the image below (code attached) [^test_wcs.py] !image-2021-05-07-15-20-42-122.png|width=410,height=396! The code below can be used to reproduce the image: {code:java}ssh lsst-devl03 source "/software/lsstsw/stack/loadLSST.bash" setup lsst_distrib setup -k -r /project/scichris/aos/phosim_utils/ python /project/scichris/aos/phosim_syseng4/phosim.py /project/scichris/aos/ps1_phosim/test_rotang/stars_comCam_PS1_high_focal_rotskypos_30.inst -i comcam -e 1 -c /project/scichris/aos/ps1_phosim/noBkgnd.cmd -p 24 -w /project/scichris/aos/ps1_phosim/test_rotang/rotskypos -s R22_S01 -o /project/scichris/aos/ps1_phosim/test_rotang/rotskypos/raw > /project/scichris/aos/ps1_phosim/test_rotang/rotskypos/starPhoSim.log 2>&1 phosim_repackager.py /project/scichris/aos/ps1_phosim/test_rotang/rotskypos/raw --out_dir /project/scichris/aos/ps1_phosim/test_rotang/rotskypos/repackaged --inst comcam {code} |
| Team | Telescope and Site [ 13500 ] |
| Status | To Do [ 10001 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | To Do [ 10001 ] |
| Status | To Do [ 10001 ] | In Progress [ 3 ] |
| Attachment | test_wcs2.py [ 49551 ] |
| Attachment | image-2021-05-10-17-41-42-123.png [ 49552 ] |
| Status | In Progress [ 3 ] | In Review [ 10004 ] |
The update looks good to me. Thanks!
| Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
| Resolution | Done [ 10000 ] | |
| Status | Reviewed [ 10101 ] | Done [ 10002 ] |
The ts_wep test files did not need an update, as in v.1.6.2 the header ROTANG was changed from 0 to 90, which would be the same now( 90-0 = 90+ 0). Tested with the attached code, resulting in a correct ROTANG with rotSkyPos = 30 (then ROTANG = 90 - 30 = 60 ) - image below. test_wcs2.py