Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-30092

Fix rotation angle for nonzero values

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ts_aos
    • Labels:

      Description

      The DM-29702 aimed to fix the rotation angle offset, and while it seemed arbitrary whether 90 +/- ROTANG is chosen, it turns out to have introduced a bug  as a result of poor choice of test angle. 

      This ticket is to correct it, and make the change  as  90 -  ROTANG

      Also, update ts_wep test files, to correct changes introduced in v1.6.2 

      Completion criteria: 

      Verify that when using non-zero rotation angle (eg. rotskypos 30) the repackager correctly creates the ROTANG. One way to test that is if together with primary header aliases ROTPA and ROTSTART  result in butler making the exposure-attached wcs that allows to translate the instance catalog to ccd pixel positions with correct orientation, as in the image below (code attached)
      test_wcs.py

       

      The code below can be used to reproduce the image: 

      ssh lsst-devl03 
      source "/software/lsstsw/stack/loadLSST.bash"
      setup lsst_distrib
      setup -k -r /project/scichris/aos/phosim_utils/
       
      python /project/scichris/aos/phosim_syseng4/phosim.py /project/scichris/aos/ps1_phosim/test_rotang/stars_comCam_PS1_high_focal_rotskypos_30.inst -i comcam -e 1 -c /project/scichris/aos/ps1_phosim/noBkgnd.cmd -p 24 -w /project/scichris/aos/ps1_phosim/test_rotang/rotskypos -s R22_S01 -o /project/scichris/aos/ps1_phosim/test_rotang/rotskypos/raw > /project/scichris/aos/ps1_phosim/test_rotang/rotskypos/starPhoSim.log 2>&1
       
      phosim_repackager.py /project/scichris/aos/ps1_phosim/test_rotang/rotskypos/raw     --out_dir /project/scichris/aos/ps1_phosim/test_rotang/rotskypos/repackaged --inst comcam
      

        Attachments

        1. image-2021-05-07-15-20-42-122.png
          image-2021-05-07-15-20-42-122.png
          1.61 MB
        2. image-2021-05-10-17-41-42-123.png
          image-2021-05-10-17-41-42-123.png
          1.61 MB
        3. test_wcs.py
          2 kB
        4. test_wcs2.py
          2 kB

          Activity

            People

            Assignee:
            ksuberlak Krzysztof Suberlak
            Reporter:
            ksuberlak Krzysztof Suberlak
            Reviewers:
            Te-Wei Tsai
            Watchers:
            Bryce Kalmbach, Krzysztof Suberlak, Te-Wei Tsai
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Start date:

                Jenkins

                No builds found.