Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-30105

Get children sources without repeatedly checking if the afw SourceCatalog is sorted by parent

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      This essentially duplicates DM-29936, which due to logic bug broke the master branch and was soon reverted. This ticket branch includes the same commits as in DM-29936 with bug fixes.

        Attachments

          Issue Links

          duplicates

          Improvement - An improvement or enhancement to an existing feature or task. DM-29936 Enable getting Children without repeatedly checking if the SourceCatalog is sorted

          • Won't Fix

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            kannawad Arun Kannawadi added a comment -

            Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/34182/pipeline

            Show
            kannawad Arun Kannawadi added a comment - Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/34182/pipeline
            Hide
            Permalink
            kannawad Arun Kannawadi added a comment -

            As before, there are two PRs and Jira picks up only one. The afw PR is essentially the same - I cherry-picked the commits from DM-29936. The PR in `meas_base` contains the old commits and a separate patch commit, which will be squashed with the buggy commit after review.

            afw: https://github.com/lsst/afw/pull/587
            meas_base: https://github.com/lsst/meas_base/pull/176

            Show
            kannawad Arun Kannawadi added a comment - As before, there are two PRs and Jira picks up only one. The afw PR is essentially the same - I cherry-picked the commits from DM-29936 . The PR in `meas_base` contains the old commits and a separate patch commit, which will be squashed with the buggy commit after review. afw: https://github.com/lsst/afw/pull/587 meas_base: https://github.com/lsst/meas_base/pull/176
            Hide
            Permalink
            fred3m Fred Moolekamp added a comment -

            Looks good. Sorry that I didn't catch that bug in my last review.

            Show
            fred3m Fred Moolekamp added a comment - Looks good. Sorry that I didn't catch that bug in my last review.
            Hide
            Permalink
            kannawad Arun Kannawadi added a comment -

            No worries, thanks Fred.

            Another more-exhaustive Jenkins run double-checking nothing is broken: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/34188/pipeline

            Show
            kannawad Arun Kannawadi added a comment - No worries, thanks Fred. Another more-exhaustive Jenkins run double-checking nothing is broken: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/34188/pipeline

              People

              Assignee:
              kannawad Arun Kannawadi
              Reporter:
              kannawad Arun Kannawadi
              Reviewers:
              Fred Moolekamp
              Watchers:
              Arun Kannawadi, Fred Moolekamp
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.