Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-30107

Streamline and clean up obs_base/pipe_tasks/ip_isr dependencies

    XMLWordPrintable

    Details

    • Urgent?:
      No

      Description

      Conversation on the RFC-775 proposal revealed that pipe_tasks depends on ip_isr via more than just Gen2 ProcessCcdTask's usage of IsrTask.  In particular, Tim Jenness says:

      The read curated calibs routine should clearly not be there – obs_base has to import pipe_tasks to use the routine and that seems completely broken.

      This is mostly tangential to RFC-775, so I think it's better to make it a separate ticket rather than part of its implementation.

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment -

            The real difficulty is working out where to put the code. obs_base uses it but it's entirely for ip_isr serializations.

            ip_isr depends on meas_algorithms which depends on obs_base via obs_test (which maybe goes away when gen2 goes away). Putting it in ip_isr (once the circular dependency goes away) then leads to obs_base depending on half the world again.

            Show
            tjenness Tim Jenness added a comment - The real difficulty is working out where to put the code. obs_base uses it but it's entirely for ip_isr serializations. ip_isr depends on meas_algorithms which depends on obs_base via obs_test (which maybe goes away when gen2 goes away). Putting it in ip_isr (once the circular dependency goes away) then leads to obs_base depending on half the world again.
            Hide
            tjenness Tim Jenness added a comment -

            I am dealing with this in DM-35035. I have moved the curated calibrations reading code to obs_base. Now that we don't have to support gen2 I was able to change the code to use the StorageClass python type for the curated calibration class and that does not need any special dependency on ip_isr.

            Show
            tjenness Tim Jenness added a comment - I am dealing with this in DM-35035 . I have moved the curated calibrations reading code to obs_base. Now that we don't have to support gen2 I was able to change the code to use the StorageClass python type for the curated calibration class and that does not need any special dependency on ip_isr.

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              jbosch Jim Bosch
              Watchers:
              Jim Bosch, John Parejko, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins Builds

                  No builds found.