Te-Wei Tsai added a comment - 12/May/21 7:38 PM I think that is just because I forgot to remove the duplicated functions. We could remove the duplication after we tested the simulation without the problem.

Te-Wei Tsai added a comment - 12/May/21 7:54 PM I just tested the latest `master` branch of ts_wep , phosim_utils , and ts_ofc v1.3.7 without the problems: [root@05f728cb542d ts_phosim]# python bin.src/opdCloseLoop.py Calculated PSSN is [0.59475346 0.589638 0.59052874 0.59292836 0.58497574 0.58628199 0.59527559 0.58779044 0.58661072]. GQ effective FWHM is 0.5433. Calculated PSSN is [0.96592765 0.96628028 0.96787884 0.966245 0.96562767 0.96761831 0.96616062 0.96611983 0.96731786]. GQ effective FWHM is 0.1212. Let me check the ts_ofc v2.0.0 and ticket branch of ts_phosim now.

Te-Wei Tsai added a comment - 12/May/21 7:57 PM - edited I have this error: [root@05f728cb542d ts_phosim]# python bin.src/opdCloseLoop.py Traceback (most recent call last): File "bin.src/opdCloseLoop.py", line 42, in <module> closeLoopTask.runOpd( File "/home/saluser/ts_phosim/python/lsst/ts/phosim/CloseLoopTask.py", line 386, in runOpd self.configOfcCalc(instName, filterType, rotCamInDeg) TypeError: configOfcCalc() takes 2 positional arguments but 4 were given and this: [root@05f728cb542d ts_phosim]# python bin.src/imgCloseLoop.py --eimage /home/saluser/ts_wep/python/lsst/ts/wep/bsc/WcsSol.py:45: FutureWarning: Gen2 Butler has been deprecated (LsstCamMapper). It will be removed sometime after v23.0 but no earlier than the end of 2021. self._camera = obs_lsst.lsstCamMapper.LsstCamMapper().camera CameraMapper INFO: Loading Posix exposure registry from . Use the default OPD field positions to be star positions. The star magnitude is chosen to be 15. CameraMapper INFO: Loading Posix exposure registry from . Traceback (most recent call last): File "bin.src/imgCloseLoop.py", line 43, in <module> closeLoopTask.runImg( File "/home/saluser/ts_phosim/python/lsst/ts/phosim/CloseLoopTask.py", line 811, in runImg self.configOfcCalc(instName, filterType, rotCamInDeg) TypeError: configOfcCalc() takes 2 positional arguments but 4 were given Tiago Ribeiro , did you update the files in ts_phosim/bin.src ?

Te-Wei Tsai added a comment - 13/May/21 5:16 AM This update looks good to me. I have some comments that will send in email. Please consider them before the merge. The main part is here: [Summary] Please help to update the script in bin.src/ to make sure the simulation can run (the minimum is to check the OPD simulation can work and converge). Maybe you could let Chris to help to do the simulation and check the converge. I have some concern to pass the filter type to python/lsst/ts/phosim/CloseLoopTask.py from the scripts in bin.src/ . Please help to check this.

Tiago Ribeiro added a comment - 21/May/21 11:55 PM Some additional information requested by TeWei: Result of running opdCloseLoop.py for comcam result of running opdCloseLoop.py for lsstfam result of running imgCLoseLoop for comcam     result of running imgCloseLoop for lsstfam     All the results are available at NCSA in /project/tribeiro/