Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-30189

Update Instrument class and tasks in ts_wep

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ts_aos
    • Labels:

      Description

      In ts_wep cwfs.Instrument gets the focus offset by converting the user input value into a string and then looking it up the value of the string in a separate configuration file. This needs to be more flexible for running at the summit and this lookup needs to be replaced by just using a value passed by the user.

        Attachments

          Issue Links

            Activity

            Hide
            ttsai Te-Wei Tsai added a comment - - edited

            The unit test on Jenkins stuck on the Jenkins build. Rob Bovill kindly suggested to add the following label in in the block of agent in Jenkinsfile:

            label 'Node2_8CPU'
            

            Therefore,

            agent {
                    // Use the docker to assign the Python version.
                    // Use the label to assign the node to run the test.
                    // It is recommended by SQUARE team do not add the label to let the
                    // system decide.
                    // But in some cases, we do need to put the label to assign the specific
                    // node to use.
                    docker {
                      image 'lsstts/develop-env:develop'
                      args "-u root --entrypoint=''"
                      label 'Node2_8CPU'
                    }
                }
            

             
            Please consider this. Thanks!

            Show
            ttsai Te-Wei Tsai added a comment - - edited The unit test on Jenkins stuck on the Jenkins build. Rob Bovill  kindly suggested to add the following label in in the block of agent in Jenkinsfile : label 'Node2_8CPU' Therefore, agent { // Use the docker to assign the Python version. // Use the label to assign the node to run the test. // It is recommended by SQUARE team do not add the label to let the // system decide. // But in some cases, we do need to put the label to assign the specific // node to use. docker { image 'lsstts/develop-env:develop' args "-u root --entrypoint=''" label 'Node2_8CPU' } }   Please consider this. Thanks!
            Hide
            jbkalmbach Bryce Kalmbach added a comment -

            Review of documentation showing how to use the new instrument configuration setup when running the Gen 3 AOS pipeline. On github here: https://github.com/lsst-ts/ts_analysis_notebooks/pull/28

            Show
            jbkalmbach Bryce Kalmbach added a comment - Review of documentation showing how to use the new instrument configuration setup when running the Gen 3 AOS pipeline. On github here:  https://github.com/lsst-ts/ts_analysis_notebooks/pull/28
            Hide
            jbkalmbach Bryce Kalmbach added a comment -

            Bruno Quint reviewed and approved documentation on the new changes on github.

            Show
            jbkalmbach Bryce Kalmbach added a comment - Bruno Quint  reviewed and approved documentation on the new changes on github.

              People

              Assignee:
              jbkalmbach Bryce Kalmbach
              Reporter:
              jbkalmbach Bryce Kalmbach
              Reviewers:
              Tiago Ribeiro
              Watchers:
              Bryce Kalmbach, Te-Wei Tsai, Tiago Ribeiro
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Due:
                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.