Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-30189

Update Instrument class and tasks in ts_wep

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ts_aos
    • Labels:

      Description

      In ts_wep cwfs.Instrument gets the focus offset by converting the user input value into a string and then looking it up the value of the string in a separate configuration file. This needs to be more flexible for running at the summit and this lookup needs to be replaced by just using a value passed by the user.

        Attachments

          Issue Links

            Activity

            No builds found.
            jbkalmbach Bryce Kalmbach created issue -
            jbkalmbach Bryce Kalmbach made changes -
            Field Original Value New Value
            Labels UW
            jbkalmbach Bryce Kalmbach made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            Hide
            ttsai Te-Wei Tsai added a comment - - edited

            The unit test on Jenkins stuck on the Jenkins build. Rob Bovill kindly suggested to add the following label in in the block of agent in Jenkinsfile:

            label 'Node2_8CPU'
            

            Therefore,

            agent {
                    // Use the docker to assign the Python version.
                    // Use the label to assign the node to run the test.
                    // It is recommended by SQUARE team do not add the label to let the
                    // system decide.
                    // But in some cases, we do need to put the label to assign the specific
                    // node to use.
                    docker {
                      image 'lsstts/develop-env:develop'
                      args "-u root --entrypoint=''"
                      label 'Node2_8CPU'
                    }
                }
            

             
            Please consider this. Thanks!

            Show
            ttsai Te-Wei Tsai added a comment - - edited The unit test on Jenkins stuck on the Jenkins build. Rob Bovill  kindly suggested to add the following label in in the block of agent in Jenkinsfile : label 'Node2_8CPU' Therefore, agent { // Use the docker to assign the Python version. // Use the label to assign the node to run the test. // It is recommended by SQUARE team do not add the label to let the // system decide. // But in some cases, we do need to put the label to assign the specific // node to use. docker { image 'lsstts/develop-env:develop' args "-u root --entrypoint=''" label 'Node2_8CPU' } }   Please consider this. Thanks!
            ajc Andrew Connolly made changes -
            Epic Link DM-28335 [ 445220 ] DM-30323 [ 500588 ]
            ajc Andrew Connolly made changes -
            Due Date 31/Mar/22
            jbkalmbach Bryce Kalmbach made changes -
            Labels UW AOS UW
            ajc Andrew Connolly made changes -
            Due Date 31/Mar/22 30/Apr/22
            ajc Andrew Connolly made changes -
            Remote Link This issue links to "Page (Confluence)" [ 33037 ]
            aclements Andy Clements made changes -
            Epic Link DM-30323 [ 500588 ] DM-29391 [ 463462 ]
            aclements Andy Clements made changes -
            Epic Link DM-29391 [ 463462 ] DM-31030 [ 560425 ]
            jbkalmbach Bryce Kalmbach made changes -
            Story Points 2 10
            ajc Andrew Connolly made changes -
            Epic Link DM-31030 [ 560425 ] DM-35161 [ 1671607 ]
            Watchers Bo Xin [X], Bryce Kalmbach, Te-Wei Tsai, Tiago Ribeiro [ Bo Xin [X], Bryce Kalmbach, Te-Wei Tsai, Tiago Ribeiro ] Bryce Kalmbach, Te-Wei Tsai, Tiago Ribeiro [ Bryce Kalmbach, Te-Wei Tsai, Tiago Ribeiro ]
            jbkalmbach Bryce Kalmbach made changes -
            Link This issue is parent task of DM-36253 [ DM-36253 ]
            jbkalmbach Bryce Kalmbach made changes -
            Story Points 10 15
            jbkalmbach Bryce Kalmbach made changes -
            Story Points 15 10
            jbkalmbach Bryce Kalmbach made changes -
            Link This issue is parent task of DM-36254 [ DM-36254 ]
            jbkalmbach Bryce Kalmbach made changes -
            Summary Update Instrument class in ts_wep Update Instrument class and tasks in ts_wep
            jbkalmbach Bryce Kalmbach made changes -
            Link This issue is parent task of DM-36323 [ DM-36323 ]
            jbkalmbach Bryce Kalmbach made changes -
            Link This issue is parent task of DM-36338 [ DM-36338 ]
            jbkalmbach Bryce Kalmbach made changes -
            Story Points 10 5
            Hide
            jbkalmbach Bryce Kalmbach added a comment -

            Review of documentation showing how to use the new instrument configuration setup when running the Gen 3 AOS pipeline. On github here: https://github.com/lsst-ts/ts_analysis_notebooks/pull/28

            Show
            jbkalmbach Bryce Kalmbach added a comment - Review of documentation showing how to use the new instrument configuration setup when running the Gen 3 AOS pipeline. On github here:  https://github.com/lsst-ts/ts_analysis_notebooks/pull/28
            jbkalmbach Bryce Kalmbach made changes -
            Reviewers Tiago Ribeiro [ tribeiro ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            jbkalmbach Bryce Kalmbach added a comment -

            Bruno Quint reviewed and approved documentation on the new changes on github.

            Show
            jbkalmbach Bryce Kalmbach added a comment - Bruno Quint  reviewed and approved documentation on the new changes on github.
            jbkalmbach Bryce Kalmbach made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            jbkalmbach Bryce Kalmbach made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

              People

              Assignee:
              jbkalmbach Bryce Kalmbach
              Reporter:
              jbkalmbach Bryce Kalmbach
              Reviewers:
              Tiago Ribeiro
              Watchers:
              Bryce Kalmbach, Te-Wei Tsai, Tiago Ribeiro
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Due:
                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.