Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-30215

"#" characters cannot be passed as arguments to SAL commands

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ts_middleware
    • Labels:
      None
    • Team:
      Architecture
    • Urgent?:
      No

      Description

      https://github.com/lsst-ts/ts_salobj/blob/develop/python/lsst/ts/salobj/csc_commander.py#L637-L638 prevents an argument containing a "#" from being passed to the command.

      One possible solution is to allow "#" to be escaped with "\".

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          ktl Kian-Tat Lim added a comment -

          I need to be able to pass URL-like strings with "fragment identifiers" to a command.

          Show
          ktl Kian-Tat Lim added a comment - I need to be able to pass URL-like strings with "fragment identifiers" to a command.
          Hide
          Permalink
          ktl Kian-Tat Lim added a comment -

          I could also add the shlex.split() in this ticket, if you'd like.

          Show
          ktl Kian-Tat Lim added a comment - I could also add the shlex.split() in this ticket, if you'd like.
          Hide
          Permalink
          rowen Russell Owen added a comment -

          As noted on github: I suggest removing the "allow trailing comments on commands" feature entirely, instead of making it more complicated.

          Please do add the shlex.split support on this ticket, if you are willing.

          Show
          rowen Russell Owen added a comment - As noted on github: I suggest removing the "allow trailing comments on commands" feature entirely, instead of making it more complicated. Please do add the shlex.split support on this ticket, if you are willing.
          Hide
          Permalink
          ktl Kian-Tat Lim added a comment -

          I have removed the comment feature and added the shlex.split().

          Show
          ktl Kian-Tat Lim added a comment - I have removed the comment feature and added the shlex.split().
          Hide
          Permalink
          rowen Russell Owen added a comment -

          Looks good. Please add a new entry to the version history before merging; I suggest v6.3.7.

          Show
          rowen Russell Owen added a comment - Looks good. Please add a new entry to the version history before merging; I suggest v6.3.7.

            People

            Assignee:
            ktl Kian-Tat Lim
            Reporter:
            ktl Kian-Tat Lim
            Reviewers:
            Russell Owen
            Watchers:
            Kian-Tat Lim, Russell Owen
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.