Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: afw
-
Labels:
-
Story Points:4
-
Epic Link:
-
Sprint:DRP S21b, DRP S22A
-
Team:Data Release Production
-
Urgent?:No
Description
There is currently no getter method to obtain PSF shape from a SourceRecord using the slots field for PSF shapes. While `base_SdssShape` has a way of obtaining from the key, this doesn't generalize to Hsm Psf moments and cannot be configured. This ticket implements a `getPsfShape` method similar to `getShape` that will return the PSF moments as an `lsst.afw.geom.Quadrupole` object.
Attachments
Issue Links
Activity
This issue is closely related to DM-30359, where `slot_PsfShape` has to be treated differently from `slot_Shape`. Having a common interface for source and PSF shapes would prevent similar confusions from happening.
Pair-coded this with Jim Bosch. We implemented this as pure-Python methods instead of mimicking the `getShape` methods implemented in C++. Jim says this can be an example for how to extend new methods on afw tables in Python.
Successful Jenkins run with more minor changes and on ci_imsim and ci_hsc: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/35572/pipeline
Thanks for the review Jim. Incorporated the comments and ran Jenkins another time FWIW.
While I can still construct the PSF shape object from `slot_PsfShape_xx`, `slot_PsfShape_yy` and `slot_PsfShape_xy`, it is cleaner to implement a method in afw that can handle the construction of the `Quadrupole` object.