Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-30284

Investigate differences in the coadd background between gen2 and gen3

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • None
    • 26
    • Data Release Production
    • No

    Description

      While testing the streak masking code, I noticed that there are pretty significant differences between the background in gen2 and gen3 for the coadd in the attached image. The satellite trail visible in the gen2 version has also disappeared in the gen3 coadd.

      Attachments

        Issue Links

          Activity

            jbosch Jim Bosch added a comment -

            I've taken a look at all of the PRs assigned to me; there are some comments that are worth addressing, but they should all be simple to address so I don't think I need to take another look unless you'd like me to.

            The change in meas_base that switches the ForcedPhotCoadd is fine in terms of compatibility with existing repos - both dataset types already exist, and they have the same dimensions and storage class, so changing the name of the input is effectively just a change to the config defaults.

            jbosch Jim Bosch added a comment - I've taken a look at all of the PRs assigned to me; there are some comments that are worth addressing, but they should all be simple to address so I don't think I need to take another look unless you'd like me to. The change in meas_base that switches the ForcedPhotCoadd is fine in terms of compatibility with existing repos - both dataset types already exist, and they have the same dimensions and storage class, so changing the name of the input is effectively just a change to the config defaults.

            Thanks, Jim.  Another Jenkins with all your suggested changes is happy. Mergeing still awaits yusras review.

            lauren Lauren MacArthur added a comment - Thanks, Jim.  Another Jenkins with all your suggested changes is happy . Mergeing still awaits yusra s review.
            yusra Yusra AlSayyad added a comment - - edited

            Primary comment is actually on the meas_base PR: the deepCoadd-> deepCoadd_calexp could go on its own ticket so that it's easier to just backport that.

            I got confused that the getGen3ExposureId was for gen2 use only and why sometimes it need to be in a try block and sometimes not.

            Also, was that ci_hsc_gen2 situation with detect_isPrimary. (i didn't understand the inline comment) Is that an oddity with the propagateVisitFlags, or is it always that hard to get primary sources these days?

            yusra Yusra AlSayyad added a comment - - edited Primary comment is actually on the meas_base PR: the deepCoadd-> deepCoadd_calexp could go on its own ticket so that it's easier to just backport that. I got confused that the getGen3ExposureId was for gen2 use only and why sometimes it need to be in a try block and sometimes not. Also, was that ci_hsc_gen2 situation with detect_isPrimary. (i didn't understand the inline comment) Is that an oddity with the propagateVisitFlags, or is it always that hard to get primary sources these days?

            Separate ticket for deepCoadd -> deepCoadd_calexp is DM-33195.

            I tried to answer all your questions on the PRs. Let me know if I was able to make some semblance of sense of it all!

            A new Jenkins is running.

            lauren Lauren MacArthur added a comment - Separate ticket for deepCoadd -> deepCoadd_calexp is DM-33195 . I tried to answer all your questions on the PRs. Let me know if I was able to make some semblance of sense of it all! A new Jenkins is running .

            A final Jenkins was green (in addition to a paranoid post-merge Jenkins run on main). Merged and done!

            lauren Lauren MacArthur added a comment - A final Jenkins was  green (in addition to a paranoid post-merge Jenkins run on main ). Merged and done!

            People

              lauren Lauren MacArthur
              csaunder Clare Saunders
              Yusra AlSayyad
              Clare Saunders, Dino Bektesevic, Fred Moolekamp, Jim Bosch, Lauren MacArthur, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.