Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-3037

remove lsst/log wrapper from Qserv

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: Qserv
    • Labels:
      None

      Description

      lsst/log API looks stable now, so removing the wrapper would simplify the code.

        Attachments

          Activity

          Hide
          jbecla Jacek Becla added a comment -

          Most have been already removed. The only remaining piece is msgCode.h. It is used in ccontrol/MergingHandler.cc and qdisp/Executive.cc. I am planning to move it to ccontrol.

          Show
          jbecla Jacek Becla added a comment - Most have been already removed. The only remaining piece is msgCode.h. It is used in ccontrol/MergingHandler.cc and qdisp/Executive.cc. I am planning to move it to ccontrol.
          Hide
          jbecla Jacek Becla added a comment -

          Fritz, can you review? I moved the msgCode.h file, the rest of lsst/log has been cleaned up gradually in the past. One less directory in core/modules!

          Show
          jbecla Jacek Becla added a comment - Fritz, can you review? I moved the msgCode.h file, the rest of lsst/log has been cleaned up gradually in the past. One less directory in core/modules!
          Hide
          fritzm Fritz Mueller added a comment -

          Yay! Left one comment in PR – should the namespace of the constants be changed log -> ccontrol as well?

          Show
          fritzm Fritz Mueller added a comment - Yay! Left one comment in PR – should the namespace of the constants be changed log -> ccontrol as well?
          Hide
          jbecla Jacek Becla added a comment -

          Yes good point, I fixed it! Thanks.

          Show
          jbecla Jacek Becla added a comment - Yes good point, I fixed it! Thanks.

            People

            • Assignee:
              fritzm Fritz Mueller
              Reporter:
              jammes Fabrice Jammes
              Reviewers:
              Fritz Mueller
              Watchers:
              Fabrice Jammes, Fritz Mueller, Jacek Becla
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel