Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-30776

Move MatchApFakesTask to pipe_tasks

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • ap_pipe, pipe_tasks
    • None

    Description

      The ap.pipe.MatchApFakesTask is a small task that cross-matches a pre-existing fakes catalog with a DIAsource catalog, for the benefit of AP-specific metrics that operate on processed fakes sources. I would like to move this task to pipe_tasks (where the original fakes code from DRP resides) so that it can also be used with more generic metrics, such as the difference imaging metrics covered by DM-30349.

      This ticket covers moving (and renaming) MatchApFakesTask, and updating our fakes pipeline(s) to match, but not any behavior changes. The fakes catalog format is shared with the DRP fakes code, so there are no compatibility problems there. The requirement for an SDMified DIAsource (rather than direct source) catalog may be too restrictive for DM-30349, but that is best addressed on that ticket.

      I am proposing this change without an RFC or deprecation period, as MatchApFakesTask is a specialized tool that is only being used internally by AP.

      Attachments

        Issue Links

          Activity

            Looks good. Assuming Jenkins is passing should be okay to merge. I noticed that you did follow https://developer.lsst.io/stack/transferring-code.html but haven't added it to the linked confluence page yet.

            cmorrison Chris Morrison [X] (Inactive) added a comment - Looks good. Assuming Jenkins is passing should be okay to merge. I noticed that you did follow https://developer.lsst.io/stack/transferring-code.html but haven't added it to the linked confluence page yet.

            Thanks for the quick review. I've logged the transfer on Confluence.

            krzys Krzysztof Findeisen added a comment - Thanks for the quick review. I've logged the transfer on Confluence.

            People

              krzys Krzysztof Findeisen
              krzys Krzysztof Findeisen
              Chris Morrison [X] (Inactive)
              Chris Morrison [X] (Inactive), Eric Bellm, Ian Sullivan, Krzysztof Findeisen
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.