Compute the modelPhotRep metrics added to validate_drp in DM-21380 with faro and inspect the test-med-1 results (DM-30822).
Jeff, could you have a look at this? Re-adding these old validate_drp metrics into faro was fairly straightforward.
I did fix some unrelated issues I noticed along the way and tested that most of the tasks run successfully on DC2 reruns, though a few are memory-intensive and wPerp continues to fail every time.
Thanks for fixing the issues you spotted!
See comments on the PR - looks (mostly) good!
Oh, and wPerp is definitely too memory intensive – a fix for that should come soon.
Thanks for the review - successful Jenkins run here.
The suggestion to re-work the S/N bin config is a good one, but I'm going to put it off for when we (inevitably, I think) decide to re-organize/refactor non-SRD metrics.