Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-30823

Add modelPhotRep metrics to faro

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • None
    • None

    Description

      Compute the modelPhotRep metrics added to validate_drp in DM-21380 with faro and inspect the test-med-1 results (DM-30822).

      Attachments

        Issue Links

          Activity

            dtaranu Dan Taranu added a comment -

            Jeff, could you have a look at this? Re-adding these old validate_drp metrics into faro was fairly straightforward.

            I did fix some unrelated issues I noticed along the way and tested that most of the tasks run successfully on DC2 reruns, though a few are memory-intensive and wPerp continues to fail every time.

            dtaranu Dan Taranu added a comment - Jeff, could you have a look at this? Re-adding these old validate_drp metrics into faro was fairly straightforward. I did fix some unrelated issues I noticed along the way and tested that most of the tasks run successfully on DC2 reruns, though a few are memory-intensive and wPerp continues to fail every time.

            Thanks for fixing the issues you spotted!

            See comments on the PR - looks (mostly) good!

            Oh, and wPerp is definitely too memory intensive – a fix for that should come soon.

            jcarlin Jeffrey Carlin added a comment - Thanks for fixing the issues you spotted! See comments on the PR - looks (mostly) good! Oh, and wPerp is definitely too memory intensive – a fix for that should come soon.
            dtaranu Dan Taranu added a comment -

            Thanks for the review - successful Jenkins run here.

            The suggestion to re-work the S/N bin config is a good one, but I'm going to put it off for when we (inevitably, I think) decide to re-organize/refactor non-SRD metrics.

            dtaranu Dan Taranu added a comment - Thanks for the review - successful Jenkins run here . The suggestion to re-work the S/N bin config is a good one, but I'm going to put it off for when we (inevitably, I think) decide to re-organize/refactor non-SRD metrics.

            People

              dtaranu Dan Taranu
              dtaranu Dan Taranu
              Jeffrey Carlin
              Dan Taranu, Jeffrey Carlin
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.