Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-30875

Improve support for nan in WriteTopic.set

    XMLWordPrintable

    Details

    • Story Points:
      1
    • Epic Link:
    • Sprint:
      TSSW Sprint - Jun 21 - Jul 05
    • Team:
      Telescope and Site
    • Urgent?:
      No

      Description

      The way WriteTopic.set compares values to see if anything changes, NaN is not equal to NaN (as is typical). Fix this so one can set a field that is NaN to NaN again to (or an array containing one or more elements that are NaN to the same array value again) without WriteTopic.set thinking the field value has changed.

      The main driver for this is to make ControllerEvent.set_put only write data if a value that is NaN (or an array containing a NaN) is truly set to a new value. Now that we have agreed to use NaN as the "no data available" signal for floats in the EFD, I expect us to be writing more NaNs to events. I need this in DM-30745.

      Also change TestCsc.assert_arrays/scalars_equal to make NaN compare equal.

        Attachments

          Issue Links

            Activity

            Hide
            rowen Russell Owen added a comment -
            Show
            rowen Russell Owen added a comment - Pull request: https://github.com/lsst-ts/ts_salobj/pull/198
            Hide
            wvreeven Wouter van Reeven added a comment -

            Reviewed on GitHub.

            Show
            wvreeven Wouter van Reeven added a comment - Reviewed on GitHub.
            Hide
            rowen Russell Owen added a comment -

            Released as v6.4.3

            Show
            rowen Russell Owen added a comment - Released as v6.4.3

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Wouter van Reeven
              Watchers:
              Russell Owen, Wouter van Reeven
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.