# Gen3 MakeWarpTask should skip a detector with no wcs/photocalib

XMLWordPrintable

#### Details

• Type: Story
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
None
• Story Points:
1
• Team:
Data Release Production
• Urgent?:
No

#### Description

As per our discussion at the June 28th Metrics Meeting in order to more gently handle known types of irrecoverable single-frame processing failures, we should allow MakeWarpTask to filter out detectors that have None for the wcs or the photocalib. These will now warn instead of Raising.

#### Activity

Hide

Looks fine.

Maybe an inline comment explaining why the readers sees the exact same line of code twice: inputs = self.filterInputs(indices=goodIndices, inputs=inputs) or rename your goodIndices to something like {(completeIndicies}} to make it different.

(I regret calling them "goodIndices" now that there are completeIndicies)

Show
Yusra AlSayyad added a comment - Looks fine. Maybe an inline comment explaining why the readers sees the exact same line of code twice: inputs = self.filterInputs(indices=goodIndices, inputs=inputs) or rename your goodIndices to something like {(completeIndicies}} to make it different. (I regret calling them "goodIndices" now that there are completeIndicies )
Hide
Kian-Tat Lim added a comment -

Unfortunately, I have to report that getSkyWcs() doesn't exist on calexp.  I guess this wasn't triggered by the Jenkins tests, but it does show up in ci_imsim.  Can this be fixed prior to the weekly?

Show
Kian-Tat Lim added a comment - Unfortunately, I have to report that getSkyWcs() doesn't exist on calexp.  I guess this wasn't triggered by the Jenkins tests, but it does show up in ci_imsim.  Can this be fixed prior to the weekly?

#### People

Assignee:
Eli Rykoff
Reporter:
Eli Rykoff
Reviewers:
Watchers:
Eli Rykoff, Jim Bosch, Kian-Tat Lim, Lauren MacArthur, Yusra AlSayyad