Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-30921

Gen3 MakeWarpTask should skip a detector with no wcs/photocalib

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_tasks
    • Labels:
      None

      Description

      As per our discussion at the June 28th Metrics Meeting in order to more gently handle known types of irrecoverable single-frame processing failures, we should allow MakeWarpTask to filter out detectors that have None for the wcs or the photocalib. These will now warn instead of Raising.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-30928 Set photoCalib to None for failed photometric fit

          • To Do

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-30927 Set calexp WCS to None for failed astrometric fit

          • Done

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            erykoff Eli Rykoff created issue -
            lauren Lauren MacArthur made changes -
            Field Original Value New Value
            Link This issue relates to DM-30927 [ DM-30927 ]
            lauren Lauren MacArthur made changes -
            Link This issue relates to DM-30928 [ DM-30928 ]
            erykoff Eli Rykoff made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            erykoff Eli Rykoff made changes -
            Reviewers Yusra AlSayyad [ yusra ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            Permalink
            yusra Yusra AlSayyad added a comment -

            Looks fine.

            Maybe an inline comment explaining why the readers sees the exact same line of code twice: inputs = self.filterInputs(indices=goodIndices, inputs=inputs) or rename your goodIndices to something like {(completeIndicies}} to make it different.

            (I regret calling them "goodIndices" now that there are completeIndicies)

            Show
            yusra Yusra AlSayyad added a comment - Looks fine. Maybe an inline comment explaining why the readers sees the exact same line of code twice: inputs = self.filterInputs(indices=goodIndices, inputs=inputs) or rename your goodIndices to something like {(completeIndicies}} to make it different. (I regret calling them "goodIndices" now that there are completeIndicies )
            yusra Yusra AlSayyad made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            erykoff Eli Rykoff made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            Hide
            Permalink
            ktl Kian-Tat Lim added a comment -

            Unfortunately, I have to report that `getSkyWcs()` doesn't exist on `calexp`.  I guess this wasn't triggered by the Jenkins tests, but it does show up in ci_imsim.  Can this be fixed prior to the weekly?

            Show
            ktl Kian-Tat Lim added a comment - Unfortunately, I have to report that `getSkyWcs()` doesn't exist on `calexp`.  I guess this wasn't triggered by the Jenkins tests, but it does show up in ci_imsim.  Can this be fixed prior to the weekly?
            erykoff Eli Rykoff made changes -
            Epic Link DM-30473 [ 509199 ]
            Story Points 1

              People

              Assignee:
              erykoff Eli Rykoff
              Reporter:
              erykoff Eli Rykoff
              Reviewers:
              Yusra AlSayyad
              Watchers:
              Eli Rykoff, Jim Bosch, Kian-Tat Lim, Lauren MacArthur, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.