Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-31017

Update Test XML and salobj to stop using octet and char data types.

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • None
    • 1
    • TSSW Sprint - Jul 05 - Jul 19
    • Telescope and Site
    • No

    Description

      Update the Test SAL component in ts_xml and the code that exercises it in ts_salobj to eliminate the "octet" and "char" fields. This is a necessary step before implementing DM-29778.

      Also make sure these field types are not use anywhere else in ts_xml.

      Attachments

        Issue Links

          Activity

            rowen Russell Owen added a comment - - edited

            I updated ts_salobj so these fields are now optional (thus preserving compatibility with older ts_xml). I also found and fixed a minor error in the IDL metadata parser (it could not find the description if there was no units entry, which only applies to the not-very-interesting <Name>ID field).

            Updated ts_xml to remove all use of char and octet field types – which was only in the Test SAL component. Note that the char maps to string and bytes maps to octet in IDL files, so we don't lose any field types, just two unused aliases.

            Pull requests:

            rowen Russell Owen added a comment - - edited I updated ts_salobj so these fields are now optional (thus preserving compatibility with older ts_xml). I also found and fixed a minor error in the IDL metadata parser (it could not find the description if there was no units entry, which only applies to the not-very-interesting <Name>ID field). Updated ts_xml to remove all use of char and octet field types – which was only in the Test SAL component. Note that the char maps to string and bytes maps to octet in IDL files, so we don't lose any field types, just two unused aliases. Pull requests: https://github.com/lsst-ts/ts_salobj/pull/201 https://github.com/lsst-ts/ts_xml/pull/470 https://github.com/lsst-ts/ts_sal/pull/132

            Reviewed on github

            rowen Russell Owen added a comment - Reviewed on github

            Released ts_salobj v6.5.2

            rowen Russell Owen added a comment - Released ts_salobj v6.5.2

            People

              rowen Russell Owen
              rowen Russell Owen
              Colin Winslow [X] (Inactive)
              Colin Winslow [X] (Inactive), Dave Mills, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.