Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-31078

MTAOS needs to send corrections that correspond to aggregatedDOF

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ts_main_telescope
    • Labels:

      Description

      When OFC is finished, the output would be published as MTAOS.logevent_degreeOfFreedom. These are arrays of 50x1. Then the next step is to convert these into corrections that can be sent to the components. For the mirrors, the MTAOS.logevent_XXCorrection should be in actuator forces. While for the hexapods, they should be dx,dy,dz,rx,ry in both cases. That is why I expect them to match.

      These corrections should correspond to aggregatedDOF , not visitDOF. My EFD analysis seems to say it is visitDOF. (See below, cells 1-12)

      https://github.com/lsst-ts/ts_notebooks/blob/6aa43c715eefcb1731500f8e7b77d3fec46a092b/bxin/aos2comp/bug_addAberr_twice.ipynb

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-29548 MTAOS communication test with M1M3, M2, and hexapods - NCSA

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            bxin Bo Xin [X] (Inactive) added a comment -

            I poked around in the MTAOS and ofc repos. This might be what needs to be changed. I could try it, but not sure what implications there might be for the unit tests.

            https://github.com/lsst-ts/ts_ofc/blob/e35adb07b7ba82b15a1866de289d678a8a906d40/python/lsst/ts/ofc/ofc.py#L274

            Show
            bxin Bo Xin [X] (Inactive) added a comment - I poked around in the MTAOS and ofc repos. This might be what needs to be changed. I could try it, but not sure what implications there might be for the unit tests. https://github.com/lsst-ts/ts_ofc/blob/e35adb07b7ba82b15a1866de289d678a8a906d40/python/lsst/ts/ofc/ofc.py#L274
            Hide
            Permalink
            ttsai Te-Wei Tsai added a comment -

            Please help to review the PR:
            https://github.com/lsst-ts/ts_ofc/pull/41

            Thanks!

            Show
            ttsai Te-Wei Tsai added a comment - Please help to review the PR: https://github.com/lsst-ts/ts_ofc/pull/41 Thanks!
            Hide
            Permalink
            tribeiro Tiago Ribeiro added a comment -

            Reviewed in GitHub.

            Show
            tribeiro Tiago Ribeiro added a comment - Reviewed in GitHub.

              People

              Assignee:
              ttsai Te-Wei Tsai
              Reporter:
              bxin Bo Xin [X] (Inactive)
              Reviewers:
              Bo Xin [X] (Inactive), Tiago Ribeiro
              Watchers:
              Bo Xin [X] (Inactive), Te-Wei Tsai, Tiago Ribeiro
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Start date:
                End date:

                  Jenkins

                  No builds found.