Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-31157

Pin requests to <2.26 to retain ability to POST NaNs in JSON

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Won't Fix
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: conda
    • Labels:
      None
    • Team:
      Architecture
    • Urgent?:
      No

      Description

      Both validate_drp and validate_drp_gen3 are attempting to write NaN float values into JSON documents that are posted to SQuaSH. These NaNs violate the JSON standard. They are accepted by Python's JSON parser/writer due to a default flag argument that relaxes the standard. The requests package used to post the documents used to also permit this non-standard usage, but in 2.26.0, a change was made to disallow NaN (or +/-Inf).

      Initially I thought this only affected validate_drp_gen3, which has other problems, so disabling that pipeline seemed like a relatively easy way out. But it turns out that validate_drp also has this problem.

      Accordingly, until a fix can be made to lsst.verify (DM-31131), it seems best to pin requests to less than 2.26.0.

        Attachments

          Issue Links

            Activity

            Hide
            ktl Kian-Tat Lim added a comment -

            The DMCCB decided that we can wait until the code is fixed since this only affects the posting of results from the validate_drp* steps and does not affect building of release artifacts.

            Show
            ktl Kian-Tat Lim added a comment - The DMCCB decided that we can wait until the code is fixed since this only affects the posting of results from the validate_drp* steps and does not affect building of release artifacts.

              People

              Assignee:
              ktl Kian-Tat Lim
              Reporter:
              ktl Kian-Tat Lim
              Watchers:
              Kian-Tat Lim
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.