Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-31190

ap_verify datasets assume default bias/flats for DECam

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ap_verify
    • Labels:
      None
    • Story Points:
      1
    • Epic Link:
    • Sprint:
      AP F21-2 (July)
    • Team:
      Alert Production
    • Urgent?:
      No

      Description

      DM-24913 changed the default calibration datasets from cpBias and cpFlat to bias and flat, respectively. Since the configs for ap_verify_hits2015 and ap_verify_ci_hits2015 do not explicitly say the dataset uses CP products (they should have, for which I have only myself to blame), they no longer run with the new obs_decam. Include explicit config overrides for cpBias and cpFlat.

        Attachments

          Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. DM-24913 obs_decam README is confusing

          • Done

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            krzys Krzysztof Findeisen created issue -
            krzys Krzysztof Findeisen made changes -
            Field Original Value New Value
            Link This issue relates to DM-24913 [ DM-24913 ]
            krzys Krzysztof Findeisen made changes -
            Description DM-24913 changed the default calibration datasets from {{cpBias}} and {{cpFlat}} to {{bias}} and {{flat}}, respectively. Since the configs for {{ap_verify_hits2015}} and {{ap_verify_ci_hits2015}} do not explicitly say the dataset uses CP products (in hindsight, they should have), they no longer run with the new {{obs_decam}}. Include explicit config overrides for {{cpBias}} and {{cpFlat}}. DM-24913 changed the default calibration datasets from {{cpBias}} and {{cpFlat}} to {{bias}} and {{flat}}, respectively. Since the configs for {{ap_verify_hits2015}} and {{ap_verify_ci_hits2015}} do not explicitly say the dataset uses CP products (they should have, for which I have only myself to blame), they no longer run with the new {{obs_decam}}. Include explicit config overrides for {{cpBias}} and {{cpFlat}}.
            krzys Krzysztof Findeisen made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            Hi Meredith Rawls, can you review this? It's 11 lines in either dataset.

            Show
            krzys Krzysztof Findeisen added a comment - Hi Meredith Rawls , can you review this? It's 11 lines in either dataset.
            krzys Krzysztof Findeisen made changes -
            Reviewers Meredith Rawls [ mrawls ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            Permalink
            mrawls Meredith Rawls added a comment -

            Thanks for catching and fixing this, and sorry for the trouble! Your fix looks good. I didn't try running ap_verify on either ticket branch; I'm assuming you did and it works.

            Show
            mrawls Meredith Rawls added a comment - Thanks for catching and fixing this, and sorry for the trouble! Your fix looks good. I didn't try running ap_verify on either ticket branch; I'm assuming you did and it works.
            mrawls Meredith Rawls made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            krzys Krzysztof Findeisen made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            Thanks for the quick feedback on Friday!

            Show
            krzys Krzysztof Findeisen added a comment - Thanks for the quick feedback on Friday!

              People

              Assignee:
              krzys Krzysztof Findeisen
              Reporter:
              krzys Krzysztof Findeisen
              Reviewers:
              Meredith Rawls
              Watchers:
              Kian-Tat Lim, Krzysztof Findeisen, Meredith Rawls
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.