Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-31279

OFC: xref does not work as expected

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ts_main_telescope
    • Labels:

      Description

      The OFC xref currently has 3 options: x00, x0, and 0. I have observed with my test at NCSA that at least x0 does not work as expected. (It worked a couple of weeks ago. So I believe a recent change to the code affected this).

      The working version of the test has a permanent link here (cells 54-110)

      https://github.com/lsst-ts/ts_notebooks/blob/6aa43c715eefcb1731500f8e7b77d3fec46a092b/bxin/aos2comp/aos2comp.ipynb

      Here is a description of what should be expected:

      when xref=x0, it means we are referencing the current positions of the DOFs for motion penalty. So if I add the same aberration twice, the visitDOF resulted from the first addAberration command should be equal to the visitDOF resulted from the 2nd addAberration command.

      So, basically, I do

      await aos.cmd_addAberration.set_start(wf = zernikes, config=config_yaml)

      await aos.cmd_issueCorrection.set_start()

      then check the event evt_degreeOfFreedom.visitDOF

      then repeat the above, the two visitDOFs should be equal. But right now they are not (in the notebook linked above, they are. But not if I re-execute the notebook with the latest version of MTAOS)

      when we set xref=x00, they will not be equal. If we compare individual DOFs, I expect the 2nd to be generally smaller than the first.

      In case that you want to check xref=0 option as well:

      my understanding is that if we have all zeros in dof_state0_filename, which is the default, the behavior should be the same as x00.

       

      Note: This ticket is also used to fix the bug of butler change in the up-stream.

        Attachments

          Issue Links

            Activity

            Hide
            ttsai Te-Wei Tsai added a comment - - edited

            After the inspection, I think this bug comes from the ts_MTAOS instead of ts_ofc. The ts_MTAOS does not pass the xref to the ts_ofc.

            Supported the xref in ts_MTAOS. However, there is a failed unit test of test_process_comcam from before. It can be reproduced by re-running the Jenkins test in develop branch. Need to investigate this.

            Show
            ttsai Te-Wei Tsai added a comment - - edited After the inspection, I think this bug comes from the ts_MTAOS instead of ts_ofc . The ts_MTAOS does not pass the xref to the ts_ofc . Supported the xref in ts_MTAOS . However, there is a failed unit test of test_process_comcam from before. It can be reproduced by re-running the Jenkins test in develop branch. Need to investigate this.
            Hide
            ttsai Te-Wei Tsai added a comment - - edited

            It looks like the change of scientific pipeline had failed the ts_wep already:
            1. in develop branch, #52 succeeds:

            https://tssw-ci.lsst.org/job/LSST_Telescope-and-Site/job/ts_wep/job/develop/52/

            2. In develop branch, #53 fails:
            https://tssw-ci.lsst.org/job/LSST_Telescope-and-Site/job/ts_wep/job/develop/53/

            I discussed with Bryce Kalmbach for the failed ts_wep in upstream, and he is kind to help to try to fix the failed tests.

            Show
            ttsai Te-Wei Tsai added a comment - - edited It looks like the change of scientific pipeline had failed the ts_wep already: 1. in develop branch, #52 succeeds: https://tssw-ci.lsst.org/job/LSST_Telescope-and-Site/job/ts_wep/job/develop/52/ 2. In develop branch, #53 fails: https://tssw-ci.lsst.org/job/LSST_Telescope-and-Site/job/ts_wep/job/develop/53/ I discussed with Bryce Kalmbach for the failed ts_wep in upstream, and he is kind to help to try to fix the failed tests.
            Hide
            ttsai Te-Wei Tsai added a comment -

            Please help to review the PR:
            https://github.com/lsst-ts/ts_MTAOS/pull/50

            Thanks!

            Show
            ttsai Te-Wei Tsai added a comment - Please help to review the PR: https://github.com/lsst-ts/ts_MTAOS/pull/50 Thanks!
            Hide
            tribeiro Tiago Ribeiro added a comment -

            PR Approved 

            Show
            tribeiro Tiago Ribeiro added a comment - PR Approved 

              People

              Assignee:
              ttsai Te-Wei Tsai
              Reporter:
              bxin Bo Xin [X] (Inactive)
              Reviewers:
              Bo Xin [X] (Inactive), Tiago Ribeiro
              Watchers:
              Bo Xin [X] (Inactive), Te-Wei Tsai, Tiago Ribeiro
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Start date:
                End date:

                  Jenkins

                  No builds found.