Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-31329

Rename ts_envsensors back to ts_ess_sensors and move all ts_ess Python modules to lsst.ts.ess.csc

    XMLWordPrintable

    Details

    • Story Points:
      1
    • Epic Link:
    • Sprint:
      TSSW Sprint - Aug 02 - Aug 16
    • Team:
      Telescope and Site
    • Urgent?:
      No

      Description

      The ts_envsensors GitHub repository was named that way to avoid a Python module name clash with ts_ess. However, a solution has been found: make sure that the ts_ess top Python module is lsst.ts.ess.csc. This ticket is for taking care of all of that.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-31426 Fix ESS Jenkins builds

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-31414 Fix Callable type annotations in all three ESS packages

          • Won't Fix

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-31416 Change ESS communications such to use a known key to identify the message type

          • Won't Fix

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            wvreeven Wouter van Reeven added a comment -

            To clarify the choices for the names of ts_ess andd ts_ess_sensors Python top modules: any underscore in the project name should result in a deeper level of the top Python module name, which is why ts_ess_sensors will have the lsst.ts.ess.sensors top Python module. However, the lack of additional underscores does not forbid adding a deeper level to the top Python module name, which is why it is allowed for ts_ess to have the lsst.ts.ess.csc top level module name without the need for renaming the ts_ess project to ts_ess_csc.

            Show
            wvreeven Wouter van Reeven added a comment - To clarify the choices for the names of ts_ess andd ts_ess_sensors Python top modules: any underscore in the project name should result in a deeper level of the top Python module name, which is why ts_ess_sensors will have the lsst.ts.ess.sensors top Python module. However, the lack of additional underscores does not forbid adding a deeper level to the top Python module name, which is why it is allowed for ts_ess to have the lsst.ts.ess.csc top level module name without the need for renaming the ts_ess project to ts_ess_csc .
            Hide
            Permalink
            wvreeven Wouter van Reeven added a comment -

            ts_ess_sensors PR:

            https://github.com/lsst-ts/ts_ess_sensors/pull/12

            ts_ess PR:

            https://github.com/lsst-ts/ts_ess/pull/40

             

            Show
            wvreeven Wouter van Reeven added a comment - ts_ess_sensors PR: https://github.com/lsst-ts/ts_ess_sensors/pull/12 ts_ess PR: https://github.com/lsst-ts/ts_ess/pull/40  
            Hide
            Permalink
            wvreeven Wouter van Reeven added a comment -

            After a discussion with Tiago and Russell:

            • Common ESS code will be extracted to ts_ess_common
            • ts_ess_sensors will be renamed to ts_ess_controller
            • ts_ess will be renamed to ts_ess_csc

            Write this up and send to Eric for the Developer Guide.

            Show
            wvreeven Wouter van Reeven added a comment - After a discussion with Tiago and Russell: Common ESS code will be extracted to ts_ess_common ts_ess_sensors will be renamed to ts_ess_controller ts_ess will be renamed to ts_ess_csc Write this up and send to Eric for the Developer Guide.
            Hide
            Permalink
            wvreeven Wouter van Reeven added a comment -
            • ts_ess_common has been created
            • ts_ess_sensors has been renamed to ts_ess_controller
            • ts_ess has been renamed to ts_ess_csc
            Show
            wvreeven Wouter van Reeven added a comment - ts_ess_common has been created ts_ess_sensors has been renamed to ts_ess_controller ts_ess has been renamed to ts_ess_csc
            Hide
            Permalink
            wvreeven Wouter van Reeven added a comment -

            ts_ess_common PR:

            https://github.com/lsst-ts/ts_ess_common/pull/1

            ts_ess_controller PR:

            https://github.com/lsst-ts/ts_ess_controller/pull/12

            ts_ess_csc PR:

            https://github.com/lsst-ts/ts_ess_csc/pull/40

             

            Show
            wvreeven Wouter van Reeven added a comment - ts_ess_common PR: https://github.com/lsst-ts/ts_ess_common/pull/1 ts_ess_controller PR: https://github.com/lsst-ts/ts_ess_controller/pull/12 ts_ess_csc PR: https://github.com/lsst-ts/ts_ess_csc/pull/40  
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Reviewed on github

            Show
            rowen Russell Owen added a comment - Reviewed on github

              People

              Assignee:
              wvreeven Wouter van Reeven
              Reporter:
              wvreeven Wouter van Reeven
              Reviewers:
              Russell Owen
              Watchers:
              Russell Owen, Wouter van Reeven
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.