Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-31355

Switch from the deprecated log.getName() to log.name

    XMLWordPrintable

    Details

    • Story Points:
      2
    • Epic Link:
    • Sprint:
      DRP S21b
    • Team:
      Data Release Production
    • Urgent?:
      No

      Description

      We are currently getting log-bombed with lines along the following:

      /software/lsstsw/stack_20210520/stack/miniconda3-py38_4.9.2-0.6.0/Linux64/ip_diffim/22.0.1-13-g00a9d746+721f44a764/python/lsst/ip/diffim/mo\
      		 
      delPsfMatch.py:494: FutureWarning: Call to deprecated method getName. (Use Python Logger compatible 'name' attribute. Will be removed after\
      		 
       v23.) -- Deprecated since version v23.
      		 
       log.log("TRACE4." + self.log.getName(), log.DEBUG,

      There are a number of instances in ip_diffim that need fixing, and it may be worth doing a quick search for any other occurrences in the stack.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-31060 Clean up some log usage in Tasks

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            lauren Lauren MacArthur added a comment -

            A quick search on GitHub also reveals instances in meas_extensions_piff and ap_verify. I will fix those here as well.

            Show
            lauren Lauren MacArthur added a comment - A quick search on GitHub also reveals instances in meas_extensions_piff and ap_verify . I will fix those here as well.
            Hide
            Permalink
            lauren Lauren MacArthur added a comment -

            Would you mind giving this a look when you get a chance? Jenkins of lsst_distrib lsst_ci ci_hsc ci_imsim ap_verify is running.

            Show
            lauren Lauren MacArthur added a comment - Would you mind giving this a look when you get a chance? Jenkins of lsst_distrib lsst_ci ci_hsc ci_imsim ap_verify is running .
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Two look okay. I think the Piff one needs a different fix because now that we have python logging the two logger lines are no longer needed at all. I have put a suggested change on the PR.

            Show
            tjenness Tim Jenness added a comment - Two look okay. I think the Piff one needs a different fix because now that we have python logging the two logger lines are no longer needed at all. I have put a suggested change on the PR.
            Hide
            Permalink
            lauren Lauren MacArthur added a comment -

            Thanks for such detailed explanations on the PRs Tim!  I've used your suggested changeset for meas_extensions_piff and the "identical reporting" option for ip_diffim.  I've kicked off another Jenkins and will wait for that to succeed before merging (so feel free to pipe in again in the next few hours if you see any remaining issues).

            Show
            lauren Lauren MacArthur added a comment - Thanks for such detailed explanations on the PRs Tim!  I've used your suggested changeset for meas_extensions_piff and the "identical reporting" option for ip_diffim .  I've kicked off another Jenkins and will wait for that to succeed before merging (so feel free to pipe in again in the next few hours if you see any remaining issues).
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            It all looks great. Thanks.

            Show
            tjenness Tim Jenness added a comment - It all looks great. Thanks.
            Hide
            Permalink
            lauren Lauren MacArthur added a comment -

            Jenkins passed and (after a minor git hiccup) all three are merged.  Thanks again!

            Show
            lauren Lauren MacArthur added a comment - Jenkins passed and (after a minor git hiccup) all three are merged.  Thanks again!

              People

              Assignee:
              lauren Lauren MacArthur
              Reporter:
              lauren Lauren MacArthur
              Reviewers:
              Tim Jenness
              Watchers:
              Lauren MacArthur, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.