Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-3136

Add & use new mask plane for out-of-bounds regions

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Add a new mask plane for regions with no data - fully vignetted, edge patches in coadd.

      This is a port of HSC-669.

        Attachments

          Issue Links

            Activity

            Hide
            swinbank John Swinbank added a comment -

            As part of this, I'm also pulling in 78685e8 from HSC's meas_algorithms, which does not have an HSC-side ticket.

            Show
            swinbank John Swinbank added a comment - As part of this, I'm also pulling in 78685e8 from HSC's meas_algorithms , which does not have an HSC-side ticket.
            Hide
            swinbank John Swinbank added a comment - - edited

            Also 88196ac and d90603d from HSC.

            Show
            swinbank John Swinbank added a comment - - edited Also 88196ac and d90603d from HSC.
            Hide
            swinbank John Swinbank added a comment - - edited

            Also 5c44605. This was part of HSC-551; the remainder of that ticket has already been merged to meas_multifit as part of DM-240.

            Show
            swinbank John Swinbank added a comment - - edited Also 5c44605 . This was part of HSC-551 ; the remainder of that ticket has already been merged to meas_multifit as part of DM-240 .
            Hide
            swinbank John Swinbank added a comment -

            Hey Lauren, do you have time for a review, please?

            The changes here are fairly short, but they do span quite a few repositories. In particular, please see the tickets/DM-3136 branch on:

            Note that I can't run the changes to the stack demo through Buildbot before merging, as it only pulls the master branch. I have tested them locally, though. Similarly, Buildbot does nothing at all with obs_subaru.

            Show
            swinbank John Swinbank added a comment - Hey Lauren, do you have time for a review, please? The changes here are fairly short, but they do span quite a few repositories. In particular, please see the tickets/ DM-3136 branch on: afw coadd_utils meas_base meas_algorithms ip_diffim pipe_tasks obs_subaru lsst_dm_stack_demo Note that I can't run the changes to the stack demo through Buildbot before merging, as it only pulls the master branch. I have tested them locally, though. Similarly, Buildbot does nothing at all with obs_subaru .
            Hide
            lauren Lauren MacArthur added a comment -

            All looks good to me. Did you check the new demo outputs against the old ones to make sure the former make sense (I imagine the changes should be minor for the most part, but perhaps at least a few cases will change significantly with the new threshold computation/masking?)

            Otherwise, modulo a few minor comments in the commits (they weren't inter-line, so I didn't bother with a pull request), you are free to merge.

            Show
            lauren Lauren MacArthur added a comment - All looks good to me. Did you check the new demo outputs against the old ones to make sure the former make sense (I imagine the changes should be minor for the most part, but perhaps at least a few cases will change significantly with the new threshold computation/masking?) Otherwise, modulo a few minor comments in the commits (they weren't inter-line, so I didn't bother with a pull request), you are free to merge.
            Hide
            swinbank John Swinbank added a comment -

            Thanks for the review! Now merged to master.

            Show
            swinbank John Swinbank added a comment - Thanks for the review! Now merged to master.

              People

              • Assignee:
                swinbank John Swinbank
                Reporter:
                swinbank John Swinbank
                Reviewers:
                Lauren MacArthur
                Watchers:
                John Swinbank, Lauren MacArthur
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel