Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-31412

Add config/imsim/charImage.py to obs_lsst

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      obs_subaru has a charImage.py and characterizeImage.py in config/ to maintain same configuration for the gen2 and gen3 pipelines.

      obs_lsst needs a charImage.py which imports characterizeImage.py (or vice versa). Gen2 verison should really import the gen3 one.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-33978 Fix references to charImage.py in configs and make characterizeImage.py the default

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-30820 Investigate effect of reducing background fit Chebyshev polynomial order in DC2

          • Done

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            yusra Yusra AlSayyad created issue -
            lskelvin Lee Kelvin made changes -
            Field Original Value New Value
            Link This issue relates to DM-30820 [ DM-30820 ]
            Hide
            Permalink
            lskelvin Lee Kelvin added a comment -

            Jenkins run for this branch.

            Show
            lskelvin Lee Kelvin added a comment - Jenkins run for this branch .
            lskelvin Lee Kelvin made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            lskelvin Lee Kelvin made changes -
            Reviewers Lauren MacArthur [ lauren ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            Permalink
            lauren Lauren MacArthur added a comment - - edited

            Thanks for the quick fix.  Could you do a quick check to make sure the config is actually taking (e.g. a simple processCcd.py with --show config=*approxOrder* should suffice).  Otherwise, LGTM!

            Show
            lauren Lauren MacArthur added a comment - - edited Thanks for the quick fix.  Could you do a quick check to make sure the config is actually taking (e.g. a simple processCcd.py with --show config=*approxOrder* should suffice).  Otherwise, LGTM!
            lauren Lauren MacArthur made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            Hide
            Permalink
            lskelvin Lee Kelvin added a comment -

            Can confirm that these configs are being picked up for DC2 processing, i.e., running the processCcd gen2 command line task:

            $ processCcd.py /datasets/DC2/repo --show config | grep approxOrderX

            without this ticket branch gives:

            ...
            		 
            config.charImage.background.approxOrderX=6
            		 
            config.charImage.detection.background.approxOrderX=6
            		 
            config.charImage.detection.tempLocalBackground.approxOrderX=6
            		 
            config.charImage.detection.tempWideBackground.approxOrderX=6
            		 
            ...

            and with it gives:

            ...
            		 
            config.charImage.background.approxOrderX=1
            		 
            config.charImage.detection.background.approxOrderX=1
            		 
            config.charImage.detection.tempLocalBackground.approxOrderX=1
            		 
            config.charImage.detection.tempWideBackground.approxOrderX=1
            		 
            ...

            Show
            lskelvin Lee Kelvin added a comment - Can confirm that these configs are being picked up for DC2 processing, i.e., running the processCcd gen2 command line task: $ processCcd.py /datasets/DC2/repo --show config | grep approxOrderX without this ticket branch gives: ... config.charImage.background.approxOrderX=6 config.charImage.detection.background.approxOrderX=6 config.charImage.detection.tempLocalBackground.approxOrderX=6 config.charImage.detection.tempWideBackground.approxOrderX=6 ... and with it gives: ... config.charImage.background.approxOrderX=1 config.charImage.detection.background.approxOrderX=1 config.charImage.detection.tempLocalBackground.approxOrderX=1 config.charImage.detection.tempWideBackground.approxOrderX=1 ...
            Hide
            Permalink
            lskelvin Lee Kelvin added a comment -

            Thanks for the quick review Lauren, much appreciated! Ticket merged and branch deleted.

            Show
            lskelvin Lee Kelvin added a comment - Thanks for the quick review Lauren, much appreciated! Ticket merged and branch deleted.
            lskelvin Lee Kelvin made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            Parejkoj John Parejko made changes -
            Link This issue relates to DM-33978 [ DM-33978 ]

              People

              Assignee:
              lskelvin Lee Kelvin
              Reporter:
              yusra Yusra AlSayyad
              Reviewers:
              Lauren MacArthur
              Watchers:
              Lauren MacArthur, Lee Kelvin, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.