Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-31455

Make a SalIndex enum for ScriptQueue in ts_idl

    XMLWordPrintable

    Details

      Description

      Add a SalIndex enum to ts_idl's ScriptQueue enums and update ScriptQueue to use it (at least to enforce that the index be one of those two values in the command-line code).

      Before doing this we need to decide if we're going to use additional indices to support some kind of script concurrency. This ticket is blocked until that decision is made.

        Attachments

          Issue Links

            Activity

            Hide
            rowen Russell Owen added a comment - - edited

            Additional changes:

            • Rename IndexEnumeration Main to MainTel (with Tiago's permission).
            • Add SalIndex enum to ts_idl for many other SAL subsystems.
            • Add logevent_largeFileObjectAvailable to AddedGenerics for several SAL subsystems (at Tiago's request).
            • Modernized unit tests in ts_idl and ts_scriptqueue to use bare asserts. In the process I found and fixed a few asserts that were not doing what they were supposed to.
            • Unified time limits in ts_scriptqueue unit tests.
            • Updated ts_scriptqueue to use pytest-black.

            Pull requests:

            Show
            rowen Russell Owen added a comment - - edited Additional changes: Rename IndexEnumeration Main to MainTel (with Tiago's permission). Add SalIndex enum to ts_idl for many other SAL subsystems. Add logevent_largeFileObjectAvailable to AddedGenerics for several SAL subsystems (at Tiago's request). Modernized unit tests in ts_idl and ts_scriptqueue to use bare asserts. In the process I found and fixed a few asserts that were not doing what they were supposed to. Unified time limits in ts_scriptqueue unit tests. Updated ts_scriptqueue to use pytest-black. Pull requests: https://github.com/lsst-ts/ts_idl/pull/76 https://github.com/lsst-ts/ts_scriptqueue/pull/66 https://github.com/lsst-ts/ts_xml/pull/507
            Hide
            pkubanek Petr Kubanek added a comment -

            Added & use enum for main telescope/AT in scripts.

            Show
            pkubanek Petr Kubanek added a comment - Added & use enum for main telescope/AT in scripts.
            Hide
            rowen Russell Owen added a comment -

            Merged all pull requests.
            Released:

            • ts_idl v3.5.0
            • ts_scriptqueue v2.9.0
            Show
            rowen Russell Owen added a comment - Merged all pull requests. Released: ts_idl v3.5.0 ts_scriptqueue v2.9.0

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Petr Kubanek
              Watchers:
              Michael Reuter, Patrick Ingraham, Petr Kubanek, Russell Owen, Tiago Ribeiro
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.